-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files #11094
8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files #11094
Conversation
👋 Welcome back iklam! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks.
@iklam This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 67 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup.
Thanks,
Serguei
Thanks @dholmes-ora @kevinjwalls @sspitsyn for the review. |
Going to push as commit 8c26d02.
Your commit was automatically rebased without conflicts. |
Here's redo for #10687. This PR has two commits:
I have run tiers 1 - 4 so hopefully I got it right this time :-)
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11094/head:pull/11094
$ git checkout pull/11094
Update a local copy of the PR:
$ git checkout pull/11094
$ git pull https://git.openjdk.org/jdk pull/11094/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11094
View PR using the GUI difftool:
$ git pr show -t 11094
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11094.diff