Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files #11094

Conversation

iklam
Copy link
Member

@iklam iklam commented Nov 10, 2022

Here's redo for #10687. This PR has two commits:

  • 739b79a is the same as in the original PR
  • 78455c0 fixes the bug in the original PR.

I have run tiers 1 - 4 so hopefully I got it right this time :-)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11094/head:pull/11094
$ git checkout pull/11094

Update a local copy of the PR:
$ git checkout pull/11094
$ git pull https://git.openjdk.org/jdk pull/11094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11094

View PR using the GUI difftool:
$ git pr show -t 11094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11094.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 10, 2022

👋 Welcome back iklam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 10, 2022
@openjdk
Copy link

openjdk bot commented Nov 10, 2022

@iklam The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 10, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 10, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks.

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@iklam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295315: [REDO] 8276687 Remove support for JDK 1.4.1 PerfData shared memory files

Reviewed-by: dholmes, kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

  • 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
  • 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
  • 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
  • c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • a7c2338: 8296900: CertificateValidity fields are not optional
  • 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
  • 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
  • 95b8405: 8296431: PushbackInputStream should override transferTo
  • e269dc0: 8293681: ResponseAPDU getData() method javadoc
  • 8c472e4: 8294217: Assertion failure: parsing found no loops but there are some
  • ... and 57 more: https://git.openjdk.org/jdk/compare/d9b25e860b0d73f5fc0890c006bfad0614b23d5c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 11, 2022
Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.
Thanks,
Serguei

@iklam
Copy link
Member Author

iklam commented Nov 16, 2022

Thanks @dholmes-ora @kevinjwalls @sspitsyn for the review.
/integrate

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

Going to push as commit 8c26d02.
Since your change was applied there have been 108 commits pushed to the master branch:

  • 8752bb4: 8296818: Enhance JMH tests java/security/Signatures.java
  • b97fc93: 7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException
  • 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
  • 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
  • 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
  • eac26f4: 8296709: WARNING: JNI call made without checking exceptions
  • 4946737: 8297047: IGV: graphContent not set when opening a new tab
  • 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
  • e72b0ac: 8296429: Remove os::supports_sse
  • 813b223: 8296926: Sort include lines of files in the include/ directory
  • ... and 98 more: https://git.openjdk.org/jdk/compare/d9b25e860b0d73f5fc0890c006bfad0614b23d5c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 16, 2022
@openjdk openjdk bot closed this Nov 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@iklam Pushed as commit 8c26d02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

4 participants