8296818: Enhance JMH tests java/security/Signatures.java

[XueleiFan]

Hi,

May I get the micro benchmarking enhancement reviewed?

Benchmark cases for RSA(SSA-PSS)/DSA are added in the PR. Here is the benchmarking number on a Linux X86_64 platform.

Benchmark                            (algorithm)  (messageLength)   Mode  Cnt     Score    Error  Units
Signatures.DSA.sign                SHA256withDSA               64  thrpt   15  2076.114 ±  6.269  ops/s
Signatures.DSA.sign                SHA256withDSA              512  thrpt   15  2080.330 ±  4.204  ops/s
Signatures.DSA.sign                SHA256withDSA             2048  thrpt   15  2074.546 ± 11.596  ops/s
Signatures.DSA.sign                SHA256withDSA            16384  thrpt   15  2029.887 ±  6.255  ops/s
Signatures.DSA.sign                SHA384withDSA               64  thrpt   15   882.339 ±  3.343  ops/s
Signatures.DSA.sign                SHA384withDSA              512  thrpt   15   881.690 ±  2.792  ops/s
Signatures.DSA.sign                SHA384withDSA             2048  thrpt   15   876.370 ±  5.779  ops/s
Signatures.DSA.sign                SHA384withDSA            16384  thrpt   15   860.463 ±  3.286  ops/s
Signatures.EdDSA.sign                    Ed25519               64  thrpt   15  1198.668 ±  4.347  ops/s
Signatures.EdDSA.sign                    Ed25519              512  thrpt   15  1199.107 ±  2.645  ops/s
Signatures.EdDSA.sign                    Ed25519             2048  thrpt   15  1191.952 ±  7.202  ops/s
Signatures.EdDSA.sign                    Ed25519            16384  thrpt   15  1112.078 ±  5.449  ops/s
Signatures.EdDSA.sign                      Ed448               64  thrpt   15   329.802 ±  5.474  ops/s
Signatures.EdDSA.sign                      Ed448              512  thrpt   15   328.258 ±  1.725  ops/s
Signatures.EdDSA.sign                      Ed448             2048  thrpt   15   322.206 ±  5.911  ops/s
Signatures.EdDSA.sign                      Ed448            16384  thrpt   15   317.814 ±  2.339  ops/s
Signatures.RSA.sign                SHA256withRSA               64  thrpt   15   834.704 ±  6.869  ops/s
Signatures.RSA.sign                SHA256withRSA              512  thrpt   15   838.794 ±  2.995  ops/s
Signatures.RSA.sign                SHA256withRSA             2048  thrpt   15   832.343 ±  3.781  ops/s
Signatures.RSA.sign                SHA256withRSA            16384  thrpt   15   833.405 ±  3.750  ops/s
Signatures.RSA.sign                SHA384withRSA               64  thrpt   15   279.930 ±  1.384  ops/s
Signatures.RSA.sign                SHA384withRSA              512  thrpt   15   280.822 ±  1.189  ops/s
Signatures.RSA.sign                SHA384withRSA             2048  thrpt   15   278.644 ±  1.608  ops/s
Signatures.RSA.sign                SHA384withRSA            16384  thrpt   15   277.631 ±  1.266  ops/s
Signatures.RSA.sign                SHA512withRSA               64  thrpt   15   126.927 ±  0.790  ops/s
Signatures.RSA.sign                SHA512withRSA              512  thrpt   15   126.572 ±  0.506  ops/s
Signatures.RSA.sign                SHA512withRSA             2048  thrpt   15   127.159 ±  0.619  ops/s
Signatures.RSA.sign                SHA512withRSA            16384  thrpt   15   126.104 ±  0.262  ops/s
Signatures.RSASSAPSS.sign   SHA256withRSASSA-PSS               64  thrpt   15   832.804 ±  4.243  ops/s
Signatures.RSASSAPSS.sign   SHA256withRSASSA-PSS              512  thrpt   15   828.386 ± 10.118  ops/s
Signatures.RSASSAPSS.sign   SHA256withRSASSA-PSS             2048  thrpt   15   831.469 ±  4.792  ops/s
Signatures.RSASSAPSS.sign   SHA256withRSASSA-PSS            16384  thrpt   15   826.325 ±  2.698  ops/s
Signatures.RSASSAPSS.sign  SHA3846withRSASSA-PSS               64  thrpt   15   276.043 ±  1.594  ops/s
Signatures.RSASSAPSS.sign  SHA3846withRSASSA-PSS              512  thrpt   15   278.548 ±  2.011  ops/s
Signatures.RSASSAPSS.sign  SHA3846withRSASSA-PSS             2048  thrpt   15   276.393 ±  2.155  ops/s
Signatures.RSASSAPSS.sign  SHA3846withRSASSA-PSS            16384  thrpt   15   274.924 ±  1.520  ops/s
Signatures.RSASSAPSS.sign   SHA512withRSASSA-PSS               64  thrpt   15   126.004 ±  0.413  ops/s
Signatures.RSASSAPSS.sign   SHA512withRSASSA-PSS              512  thrpt   15   127.211 ±  0.312  ops/s
Signatures.RSASSAPSS.sign   SHA512withRSASSA-PSS             2048  thrpt   15   127.200 ±  0.338  ops/s
Signatures.RSASSAPSS.sign   SHA512withRSASSA-PSS            16384  thrpt   15   126.327 ±  0.520  ops/s
Signatures.sign                        secp256r1               64  thrpt   15  1523.564 ± 22.411  ops/s
Signatures.sign                        secp256r1              512  thrpt   15  1529.083 ±  5.903  ops/s
Signatures.sign                        secp256r1             2048  thrpt   15  1530.112 ±  7.832  ops/s
Signatures.sign                        secp256r1            16384  thrpt   15  1500.652 ±  1.936  ops/s
Signatures.sign                        secp384r1               64  thrpt   15   642.752 ± 11.175  ops/s
Signatures.sign                        secp384r1              512  thrpt   15   645.279 ±  3.632  ops/s
Signatures.sign                        secp384r1             2048  thrpt   15   632.866 ±  4.137  ops/s
Signatures.sign                        secp384r1            16384  thrpt   15   624.020 ±  6.282  ops/s
Signatures.sign                        secp521r1               64  thrpt   15   319.333 ±  1.587  ops/s
Signatures.sign                        secp521r1              512  thrpt   15   320.025 ±  0.890  ops/s
Signatures.sign                        secp521r1             2048  thrpt   15   309.922 ±  9.569  ops/s
Signatures.sign                        secp521r1            16384  thrpt   15   317.070 ±  0.930  ops/s

Thanks,
Xuelei

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296818: Enhance JMH tests java/security/Signatures.java

Reviewers

• Weijun Wang (@wangweij - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11131/head:pull/11131
$ git checkout pull/11131

Update a local copy of the PR:
$ git checkout pull/11131
$ git pull https://git.openjdk.org/jdk pull/11131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11131

View PR using the GUI difftool:
$ git pr show -t 11131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11131.diff

[bridgekeeper]

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@XueleiFan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (df9ad369)
• 01: Full - Incremental (1506eda6)
• 00: Full (67be4fe7)

[openjdk]

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296818: Enhance JMH tests java/security/Signatures.java

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• 6a60d31: 8295369: Update LCMS to 2.14
• 0cbf084: 8296969: C1: PrintC1Statistics is broken after JDK-8292878
• f662a06: 8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols
• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• ... and 29 more: https://git.openjdk.org/jdk/compare/657a0b2f1564e1754dbd64b776c53a52c480c901...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[XueleiFan]

/integrate

[openjdk]

Going to push as commit 8752bb4.
Since your change was applied there have been 60 commits pushed to the master branch:

• b97fc93: 7132279: (ch) SeekableByteChannel operation may throw Non{Readable,Writable}ChannelException
• 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
• 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
• 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
• eac26f4: 8296709: WARNING: JNI call made without checking exceptions
• 4946737: 8297047: IGV: graphContent not set when opening a new tab
• 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
• e72b0ac: 8296429: Remove os::supports_sse
• 813b223: 8296926: Sort include lines of files in the include/ directory
• 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
• ... and 50 more: https://git.openjdk.org/jdk/compare/657a0b2f1564e1754dbd64b776c53a52c480c901...master

Your commit was automatically rebased without conflicts.

[openjdk]

@XueleiFan Pushed as commit 8752bb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.