Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar #11150

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Nov 15, 2022

This test was problem listed with "some tests that leave windows open on the desktop" reason

The main issue with the test is that it may pass, but in fact the actual test was not even performed.
jtreg kills the test window after exiting main and ends the test before it double clicks on window's title(actual test starts from windowActivated event).

So the test was refactored and stabilized:

  • robot invocation moved from EDT to main thread.
  • throwing test exception is performed only after frame is disposed
  • extra delay added after showing window.

Old Ubuntu 16.04 and macOS 10.10.5 failures is no longer reproducible on modern systems.

CI testing looks good.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11150/head:pull/11150
$ git checkout pull/11150

Update a local copy of the PR:
$ git checkout pull/11150
$ git pull https://git.openjdk.org/jdk pull/11150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11150

View PR using the GUI difftool:
$ git pr show -t 11150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11150.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2022

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@azvegint The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 15, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

  • 39dda24: 8157173: [macosx] java/awt/Robot/ModifierRobotKey/ModifierRobotKeyTest.java fails
  • 51f690d: 8297134: Add a @sealedGraph tag to InetAddress
  • 3eb6d0e: 8291991: Adjust the "shared class paths mismatch" message if class path logging is enabled
  • eac26f4: 8296709: WARNING: JNI call made without checking exceptions
  • 4946737: 8297047: IGV: graphContent not set when opening a new tab
  • 8b1ff9e: 8297132: BACKOUT JDK-8296889: Race condition when cancelling a request
  • e72b0ac: 8296429: Remove os::supports_sse
  • 813b223: 8296926: Sort include lines of files in the include/ directory
  • 8cdcec4: 8296774: Removed default MEMFLAGS value from CHeapBitMap
  • c3b285a: 8296916: RISC-V: Move some small macro-assembler functions to header file
  • ... and 41 more: https://git.openjdk.org/jdk/compare/b0edfc1159b160eb329a066dc2805c22937a5da8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 16, 2022
@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit 2fc340a.
Since your change was applied there have been 133 commits pushed to the master branch:

  • e420661: 8297238: RISC-V: C2: Use Matcher::vector_element_basic_type when checking for vector element type in predicate
  • 891c706: 8295276: AArch64: Add backend support for half float conversion intrinsics
  • 3c09498: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 45d1807: 6312651: Compiler should only use verified interface types for optimization
  • bcc6b12: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
  • fc61658: 8294591: Fix cast-function-type warning in TemplateTable
  • 544e317: 8059632: Method reference compilation uses incorrect qualifying type
  • 651e547: 8297217: Incorrect generation name in the heap verification log message with Serial GC
  • dd55310: 8297303: ProblemList java/awt/Mouse/EnterExitEvents/DragWindowTest.java on macosx-all
  • 3ea8971: 8269817: serviceability/jvmti/DynamicCodeGenerated/DynamicCodeGeneratedTest.java timed out with -Xcomp
  • ... and 123 more: https://git.openjdk.org/jdk/compare/b0edfc1159b160eb329a066dc2805c22937a5da8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@azvegint Pushed as commit 2fc340a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants