-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8148041: Test java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick fails on Ubuntu with mouseReleased event after double click on title bar #11150
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
Webrevs
|
test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java
Outdated
Show resolved
Hide resolved
@azvegint This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 51 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 2fc340a.
Your commit was automatically rebased without conflicts. |
This test was problem listed with "some tests that leave windows open on the desktop" reason
The main issue with the test is that it may pass, but in fact the actual test was not even performed.
jtreg
kills the test window after exiting main and ends the test before it double clicks on window's title(actual test starts fromwindowActivated
event).So the test was refactored and stabilized:
Old Ubuntu 16.04 and macOS 10.10.5 failures is no longer reproducible on modern systems.
CI testing looks good.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11150/head:pull/11150
$ git checkout pull/11150
Update a local copy of the PR:
$ git checkout pull/11150
$ git pull https://git.openjdk.org/jdk pull/11150/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11150
View PR using the GUI difftool:
$ git pr show -t 11150
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11150.diff