8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols

[caoman]

Hi all,

Could anyone review this cleanup to remove dead symbol "sysThreadAvailableStackWithSlack"? See https://bugs.openjdk.org/browse/JDK-8296970 for more details.

-Man

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11156/head:pull/11156
$ git checkout pull/11156

Update a local copy of the PR:
$ git checkout pull/11156
$ git pull https://git.openjdk.org/jdk pull/11156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11156

View PR using the GUI difftool:
$ git pr show -t 11156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11156.diff

[bridgekeeper]

👋 Welcome back manc! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@caoman The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4a9aedfd)

[caoman]

/label add hotspot-runtime

[caoman]

/label remove build

[openjdk]

@caoman
The hotspot-runtime label was successfully added.

[openjdk]

@caoman
The build label was successfully removed.

[RealCLanger]

Looks good. I think it's a remnant of the Solaris port.

[openjdk]

@caoman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296970: Remove sysThreadAvailableStackWithSlack from hotspot-symbols

Reviewed-by: clanger, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

• c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
• a45c9af: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"
• d0fae43: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
• 6f467cd: 8295934: IGV: keep node selection when changing view or graph
• 9adb728: 8295070: Introduce more target combinations for compiler flags
• 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
• 5551cb6: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
• 8a9eabb: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[caoman]

/integrate

[caoman]

Thank you for the reviews!

[openjdk]

Going to push as commit f662a06.
Since your change was applied there have been 16 commits pushed to the master branch:

• 7357a1a: 8296889: Race condition when cancelling a request
• 87530e6: 8296913: Correct enable preview idiom in JdbLastErrorTest.java
• fafe682: 8295861: get rid of list argument in debug agent's removeNode() API
• 216c6f6: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
• 6aef3a4: 8262435: Clarify the behavior of a few inherited ZipInputStream methods
• c042b8e: 8294731: Improve multiplicative inverse for secp256r1 implementation
• d3051a7: 8296736: Some PKCS9Attribute can be created but cannot be encoded
• decb1b7: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
• c49e484: 8294739: jdk/jshell/ToolShiftTabTest.java timed out
• a45c9af: 8295814: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected [2] but found [1]"
• ... and 6 more: https://git.openjdk.org/jdk/compare/873eccde01895de06e2216f6838d52d07188addd...master

Your commit was automatically rebased without conflicts.

[openjdk]

@caoman Pushed as commit f662a06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.