Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14 #11176

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 15, 2022

This reverts commit 6a60d31.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11176/head:pull/11176
$ git checkout pull/11176

Update a local copy of the PR:
$ git checkout pull/11176
$ git pull https://git.openjdk.org/jdk pull/11176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11176

View PR using the GUI difftool:
$ git pr show -t 11176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11176.diff

@dcubed-ojdk
Copy link
Member Author

/label add hotspot-runtime
/label add client

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review November 15, 2022 22:46
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-runtime hotspot-runtime-dev@openjdk.org labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@dcubed-ojdk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 15, 2022

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this Dan.

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the fast review. I'm waiting for my Mach5 Tier1 linux
builds to pass...

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2022
@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit bd3acbe.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@dcubed-ojdk Pushed as commit bd3acbe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prrace
Copy link
Contributor

prrace commented Nov 15, 2022

No don't back it out

@prrace
Copy link
Contributor

prrace commented Nov 15, 2022

There's a one line build fix.

@prrace
Copy link
Contributor

prrace commented Nov 15, 2022

aah too late

@prrace
Copy link
Contributor

prrace commented Nov 15, 2022

It looks like another PR removed a disabled warning that was needed by this PR

@prrace
Copy link
Contributor

prrace commented Nov 15, 2022

all academic now since this was pushed

@dcubed-ojdk dcubed-ojdk deleted the BACKOUT-8295369 branch November 16, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants