New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297089: [BACKOUT] JDK-8297088 Update LCMS to 2.14 #11176
Conversation
This reverts commit 6a60d31.
/label add hotspot-runtime |
👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into |
@dcubed-ojdk |
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this Dan.
@dholmes-ora - Thanks for the fast review. I'm waiting for my Mach5 Tier1 linux |
@dcubed-ojdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit bd3acbe. |
@dcubed-ojdk Pushed as commit bd3acbe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
No don't back it out |
There's a one line build fix. |
aah too late |
It looks like another PR removed a disabled warning that was needed by this PR |
all academic now since this was pushed |
This reverts commit 6a60d31.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11176/head:pull/11176
$ git checkout pull/11176
Update a local copy of the PR:
$ git checkout pull/11176
$ git pull https://git.openjdk.org/jdk pull/11176/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11176
View PR using the GUI difftool:
$ git pr show -t 11176
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11176.diff