JDK-8290845: Consider an alternative item separator for multi-item option values

[jonathan-gibbons]

Please review a medium simple update to prefer the use of comma (,) instead of colon (:) in certain options taking a list of values. Options taking a search path (like --class-path, --source-path, etc) are not affected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8290845: Consider an alternative item separator for multi-item option values
• JDK-8295858: Consider an alternative item separator for multi-item option values (CSR)

Reviewers

• Pavel Rappo (@pavelrappo - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11178/head:pull/11178
$ git checkout pull/11178

Update a local copy of the PR:
$ git checkout pull/11178
$ git pull https://git.openjdk.org/jdk pull/11178/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11178

View PR using the GUI difftool:
$ git pr show -t 11178

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11178.diff

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (0dc6f970)
• 01: Full - Incremental (84666156)
• 00: Full (aeca049f)

[pavelrappo]

Not saying that we should do anything about it, but I would be surprised if there were no such tokenization functionality in the JDK API.

[RogerRiggs]

None of the JDK simple tokenizers supports handling of escape characters.
But a Pattern/Matcher could be used.

[pavelrappo]

Looks good to me.

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290845: Consider an alternative item separator for multi-item option values

Reviewed-by: prappo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• c56c69e: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
• 6fd1442: 8296743: Tighten Class.getModifiers spec for array classes
• 3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
• 43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit 52494df.
Since your change was applied there have been 4 commits pushed to the master branch:

• c56c69e: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
• 6fd1442: 8296743: Tighten Class.getModifiers spec for array classes
• 3a15e84: 8297258: Typo in java -help referencing -disable-@files instead of --disable-@files
• 43ce047: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit 52494df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.