JDK-8293177: Verify version numbers in legal files

[hns]

Please review the addition of a new JavaDoc test to check the version of 3rd party libraries in legal files against the versions of actual library code. The skeleton for this test (mostly looking up files in the source tree) was taken from CheckManPageOptions.java. The test uses a regular expression to extract the name and version of 3rd party libraries in the share/legal directory and then matches these strings against the contents of the actual library files.

The 3rd party libraries currently in use by JavaDoc are jQuery and jQuery-UI so the test infrastructure has some bits that facilitate JavaScript code such as support for both minified and unprocessed files, but it should work equally well for Java and other code.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8293177: Verify version numbers in legal files

Reviewers

• Jonathan Gibbons (@jonathan-gibbons - Reviewer) ⚠️ Review applies to 3d8e7826

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11211/head:pull/11211
$ git checkout pull/11211

Update a local copy of the PR:
$ git checkout pull/11211
$ git pull https://git.openjdk.org/jdk pull/11211/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11211

View PR using the GUI difftool:
$ git pr show -t 11211

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11211.diff

[bridgekeeper]

👋 Welcome back hannesw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@hns The following label will be automatically applied to this pull request:

• javadoc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0ae44c97)
• 00: Full (3d8e7826)

[jonathan-gibbons]

Approved, with an optional comment about code style

[openjdk]

@hns This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293177: Verify version numbers in legal files

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 218 new commits pushed to the master branch:

• b27a61e: 8297216: Search results omit some methods
• 33dfc7d: 8296954: G1: Enable parallel scanning for heap region remset
• 6f06f44: 8297242: Use-after-free during library unloading on Linux
• 4e8e853: 6788481: CellEditorListener.editingCanceled is never called
• 692bedb: 8297106: Remove the -Xcheck:jni local reference capacity checking
• 05128c2: 8286185: The Java manpage can be more platform inclusive
• d450314: 8297276: Remove thread text from Subject.current
• cdf9ed0: 8297528: java/io/File/TempDirDoesNotExist.java test failing on windows-x64
• 105d9d7: 8295351: java/lang/Float/Binary16Conversion.java fails with "Unexpected result of converting"
• a80552e: 8236919: Refactor com.sun.tools.javac.main.CommandLine into a reusable module for other JDK tools
• ... and 208 more: https://git.openjdk.org/jdk/compare/d0fae43e89a73e9d73b074fa12276c43ba629278...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[hns]

/integrate

[openjdk]

Going to push as commit 69ede5b.
Since your change was applied there have been 228 commits pushed to the master branch:

• cd6bebb: 8247645: ChaCha20 intrinsics
• 33587ff: 8292625: jshell crash on "var a = a"
• 2deb318: 8297065: DerOutputStream operations should not throw IOExceptions
• d83a07b: 8297200: java/net/httpclient/SpecialHeadersTest.java failed once in AssertionError due to selector thread remaining alive
• 5d2772a: 8297424: java/net/httpclient/AsyncExecutorShutdown.java fails in AssertionError due to misplaced assert
• 361b50e: 8292594: Use CSS custom properties for all fonts and colors
• 42b60ed: 8297030: Reduce Default Keep-Alive Timeout Value for httpclient
• 1301fb0: 8296470: Refactor VMError::report STEP macro to improve readability
• 48017b1: 8296804: Document HttpClient configuration properties in java.net.http module-info
• bd51b7e: 8296645: org.openjdk.bench.javax.tools.Javac leaves class files in current directory
• ... and 218 more: https://git.openjdk.org/jdk/compare/d0fae43e89a73e9d73b074fa12276c43ba629278...master

Your commit was automatically rebased without conflicts.

[openjdk]

@hns Pushed as commit 69ede5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.