New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297129: Inflater documentation refers to 'deflate' methods #11232
Conversation
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@@ -46,7 +46,7 @@ | |||
* This class inflates sequences of ZLIB compressed bytes. The input byte | |||
* sequence is provided in either byte array or byte buffer, via one of the | |||
* {@code setInput()} methods. The output byte sequence is written to the | |||
* output byte array or byte buffer passed to the {@code deflate()} methods. | |||
* output byte array or byte buffer passed to the {@code inflate()} methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay but probably should be a link as it's first use of inflate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had thought about it too, but I realized that it talks of inflate "methods" (there are more than one inflate methods with different parameters). So I suspect it was intentional to use {@code}
instead of {@link}
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, we can leave it as a code tag. At some point I suspect the class description of both Inflater and Deflater will need to be replaced as they are missing so much.
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 61 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you Alan and Lance for the reviews. |
/integrate |
Going to push as commit 2f2d404.
Your commit was automatically rebased without conflicts. |
Can I please get a review for this doc only change which fixes the javadoc of java.util.zip.Inflater class? As noted in https://bugs.openjdk.org/browse/JDK-8297129, there's a typo in the javadoc. This commit fixes that.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11232/head:pull/11232
$ git checkout pull/11232
Update a local copy of the PR:
$ git checkout pull/11232
$ git pull https://git.openjdk.org/jdk pull/11232/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11232
View PR using the GUI difftool:
$ git pr show -t 11232
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11232.diff