Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296672: Implementation of Virtual Threads (Second Preview) #11235

Closed
wants to merge 2 commits into from

Conversation

AlanBateman
Copy link
Contributor

@AlanBateman AlanBateman commented Nov 18, 2022

JEP 436 proposes a second preview of Virtual Threads to allow time for more feedback and to get more experience with this feature. There is no change in direction, no API changes, and no bulk update of the implementation. For the implementation, there has been ~35 changes/issues pushed to the main line, and a few more coming. For this PR, we just bump the JEP number used by javadoc from 425 to 436.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8296672: Implementation of Virtual Threads (Second Preview)
  • JDK-8296673: Implementation of Virtual Threads (Second Preview) (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11235/head:pull/11235
$ git checkout pull/11235

Update a local copy of the PR:
$ git checkout pull/11235
$ git pull https://git.openjdk.org/jdk pull/11235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11235

View PR using the GUI difftool:
$ git pr show -t 11235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11235.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@AlanBateman The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org csr Pull request needs approved CSR before integration labels Nov 18, 2022
@AlanBateman AlanBateman marked this pull request as ready for review November 18, 2022 17:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296672: Implementation of Virtual Threads (Second Preview)

Reviewed-by: mchung, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2022
@AlanBateman
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

Going to push as commit ccc69af.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 5a3439d: 4677581: ColorModel.getComponentSize()-wrong conditions for ArrayIndexOutOfBoundsExceptio
  • 27bbe7b: 8297976: Remove sun.net.ProgressMonitor and related classes
  • 085f96c: 8295258: Add BasicType argument to AccessInternal::decorator_fixup
  • 1c2a093: 8298147: Clang warns about pointless comparisons
  • 8ea369a: 8298171: Missing newline in the example output of -Xlog:help
  • acf96c6: 8290432: C2 compilation fails with assert(node->_last_del == _last) failed: must have deleted the edge just produced
  • ce89673: 8297804: (tz) Update Timezone Data to 2022g
  • 62baff5: 8298221: Problem list gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java on macosx-aarch64
  • 16a5901: 8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
  • b4da0ee: 8296507: GCM using more memory than necessary with in-place operations
  • ... and 7 more: https://git.openjdk.org/jdk/compare/1e468320dc6e495343dbdf392cbcbda79672c7ad...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2022
@openjdk openjdk bot closed this Dec 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@AlanBateman Pushed as commit ccc69af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants