-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8296804: Document HttpClient configuration properties in java.net.http module-info #11241
Closed
Michael-Mc-Mahon
wants to merge
12
commits into
openjdk:master
from
Michael-Mc-Mahon:http.properties
+132
−2
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4a99c86
first draft
Michael-Mc-Mahon 284aa8e
update after Daniel's review
Michael-Mc-Mahon 22fca6f
Merge branch 'master' into http.properties
Michael-Mc-Mahon e553040
update after review round 2
Michael-Mc-Mahon 1faf6da
removed trailing whitespace
Michael-Mc-Mahon 1d6447c
update to SSL cert check property
Michael-Mc-Mahon 5538008
update to be compatible with JDK-8297030
Michael-Mc-Mahon dcdefaf
update after comments
Michael-Mc-Mahon 2d02ffa
Merge branch 'master' into http.properties
Michael-Mc-Mahon 7fda266
reformatting change only
Michael-Mc-Mahon 608239c
changed link to linkplain
Michael-Mc-Mahon cd2efa0
copyright update
Michael-Mc-Mahon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Michael, is it intentional that we haven't documented
content
in this list?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing that omission Jai!