JDK-8297309: Memory leak in ShenandoahFullGC

[jcking]

Signed-off-by: Justin King jcking@google.com

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297309: Memory leak in ShenandoahFullGC

Reviewers

• Roman Kennke (@rkennke - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11255/head:pull/11255
$ git checkout pull/11255

Update a local copy of the PR:
$ git checkout pull/11255
$ git pull https://git.openjdk.org/jdk pull/11255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11255

View PR using the GUI difftool:
$ git pr show -t 11255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11255.diff

[bridgekeeper]

👋 Welcome back jcking! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jcking The following labels will be automatically applied to this pull request:

• hotspot-gc
• shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (52348782)

[rkennke]

Ouch. Good catch. Patch looks good, thank you!

[openjdk]

@jcking This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297309: Memory leak in ShenandoahFullGC

Reviewed-by: rkennke, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• 2f83b5c: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
• 50f9043: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread
• 99d3840: 8297359: RISC-V: improve performance of floating Max Min intrinsics
• 6c05771: 8295447: NullPointerException with invalid pattern matching construct in constructor call
• 76a24c3: 8297145: Add a @sealedGraph tag to ConstantDesc
• 099b42f: 8297148: Add a @sealedGraph tag to CallSite
• 85ddd8f: 8295253: Remove kludge from v1_0/PerfDataBuffer.java
• 952e100: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• 08e6a82: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run
• 4f65570: 8294583: JShell: NPE in switch with non existing record pattern
• ... and 78 more: https://git.openjdk.org/jdk/compare/544e31722528d12fae0eb19271f85886680801a6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rkennke, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[shipilev]

I thought ShenandoahFullGC is eternal, but apparently we create it as scoped object every time we need to go for Full GC. Oof.

Looks good!

[jcking]

/integrate

[openjdk]

@jcking
Your change (at version 5234878) is now ready to be sponsored by a Committer.

[shipilev]

/integrate

[openjdk]

@shipilev Only the author (@jcking) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

[shipilev]

/sponsor

[openjdk]

Going to push as commit b80f5af.
Since your change was applied there have been 92 commits pushed to the master branch:

• 81eb5fb: 8297534: Specify the size of MEMFLAGS
• 012dafe: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list
• 43d1173: 8286302: Port JEP 425 to PPC64
• d610211: 8297408: Consolidate code in runtime/ErrorHandling
• 2f83b5c: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
• 50f9043: 8297451: ProcessHandleImpl should assert privilege when modifying reaper thread
• 99d3840: 8297359: RISC-V: improve performance of floating Max Min intrinsics
• 6c05771: 8295447: NullPointerException with invalid pattern matching construct in constructor call
• 76a24c3: 8297145: Add a @sealedGraph tag to ConstantDesc
• 099b42f: 8297148: Add a @sealedGraph tag to CallSite
• ... and 82 more: https://git.openjdk.org/jdk/compare/544e31722528d12fae0eb19271f85886680801a6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev @jcking Pushed as commit b80f5af.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.