Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297385: Remove duplicated null typos in javadoc #11311

Closed
wants to merge 1 commit into from

Conversation

dongxuwang
Copy link
Contributor

@dongxuwang dongxuwang commented Nov 23, 2022


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11311/head:pull/11311
$ git checkout pull/11311

Update a local copy of the PR:
$ git checkout pull/11311
$ git pull https://git.openjdk.org/jdk pull/11311/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11311

View PR using the GUI difftool:
$ git pr show -t 11311

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11311.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back dongxuwang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dongxuwang The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 23, 2022
@dongxuwang dongxuwang changed the title 8297385: Remove duplicated null typo in javadoc 8297385: Remove duplicated null typos in javadoc Nov 23, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2022

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dongxuwang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297385: Remove duplicated null typos in javadoc

Reviewed-by: dfuchs, rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 09ac9eb: 8297533: ProblemList java/io/File/TempDirDoesNotExist.java test failing on windows-x64
  • 5325145: 8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64
  • 91cd8a0: 8297525: jdk/jshell/ToolBasicTest.java fails after JDK-8295984
  • 6dc4d89: 7181214: Need specify SKF translateKey(SecurityKey) method requires instance of PBEKey for PBKDF2 algorithms
  • 2afb4c3: 8297338: JFR: RemoteRecordingStream doesn't respect setMaxAge and setMaxSize
  • 8df3bc4: 8290313: Produce warning when user specified java.io.tmpdir directory doesn't exist
  • 086763a: 8297154: Improve safepoint cleanup logging
  • e6e57fe: 8297507: Update header after JDK-8297230
  • bc59f2a: 8295984: Remove unexpected JShell feature
  • 0d93ab9: 8297000: [jib] Add more friendly warning for proxy issues
  • ... and 8 more: https://git.openjdk.org/jdk/compare/09f70dad2fe3f0691afacded6c38f61fa8a0d28d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @RogerRiggs) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 23, 2022
Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dongxuwang
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dongxuwang
Your change (at version f51269e) is now ready to be sponsored by a Committer.

@y1yang0
Copy link
Member

y1yang0 commented Nov 25, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 25, 2022

Going to push as commit 0ed8b33.
Since your change was applied there have been 34 commits pushed to the master branch:

  • 1fb9dad: 8296419: [REDO] JDK-8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
  • 2f47f83: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
  • 87d1097: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation
  • 390e69a: 8297150: Add a @sealedGraph tag to Reference
  • 8effaa8: 8223783: sun/net/www/http/HttpClient/MultiThreadTest.java sometimes detect threads+1 connections
  • ab1f9ff: 8051627: Invariants about java.net.URI resolve and relativize are wrong
  • df6cf1e: 8296886: Fix various include sort order issues
  • 5e196b4: 8297476: Increase InlineSmallCode default from 1000 to 2500 for RISC-V
  • 070a84c: 8297192: Warning generating API docs for javax.management.MBeanServer: overridden methods do not document exception type
  • 3c4d520: 8296671: [JFR] jdk.ContainerConfiguration event should include host total memory
  • ... and 24 more: https://git.openjdk.org/jdk/compare/09f70dad2fe3f0691afacded6c38f61fa8a0d28d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2022
@openjdk openjdk bot closed this Nov 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@kelthuzadx @dongxuwang Pushed as commit 0ed8b33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
4 participants