Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64 #11333

Closed
wants to merge 2 commits into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Nov 23, 2022

A trivial fix to ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11333/head:pull/11333
$ git checkout pull/11333

Update a local copy of the PR:
$ git checkout pull/11333
$ git pull https://git.openjdk.org/jdk pull/11333/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11333

View PR using the GUI difftool:
$ git pr show -t 11333

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11333.diff

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review November 23, 2022 20:49
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297529: ProblemList javax/swing/JFileChooser/8046391/bug8046391.java on windows-x64

Reviewed-by: naoto, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dcubed-ojdk
Copy link
Member Author

@naotoj and @azvegint - Thanks for the fast reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 5325145.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@dcubed-ojdk Pushed as commit 5325145.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8297529 branch November 23, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants