Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss #11377

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 27, 2022

java.util.Enumeration is a legacy interface from java 1.0.
There are a few places with cycles which use it to iterate over collections. We can replace this manual cycle with enchanced-for, which is shorter and easier to read.

sun.security.jgss.ProviderList#addAllMechsFromProvider
sun.security.jgss.GSSCredentialImpl#dispose
sun.security.jgss.GSSCredentialImpl#getRemainingLifetime
sun.security.jgss.GSSCredentialImpl#getUsage()
sun.security.jgss.GSSCredentialImpl#getElements


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11377/head:pull/11377
$ git checkout pull/11377

Update a local copy of the PR:
$ git checkout pull/11377
$ git pull https://git.openjdk.org/jdk pull/11377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11377

View PR using the GUI difftool:
$ git pr show -t 11377

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11377.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2022

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2022
@openjdk
Copy link

openjdk bot commented Nov 27, 2022

@turbanoff The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 27, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2022

Webrevs

Copy link
Contributor

@wangweij wangweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297683: Use enhanced-for cycle instead of Enumeration in java.security.jgss

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 69ede5b: 8293177: Verify version numbers in legal files
  • cd6bebb: 8247645: ChaCha20 intrinsics
  • 33587ff: 8292625: jshell crash on "var a = a"
  • 2deb318: 8297065: DerOutputStream operations should not throw IOExceptions
  • d83a07b: 8297200: java/net/httpclient/SpecialHeadersTest.java failed once in AssertionError due to selector thread remaining alive
  • 5d2772a: 8297424: java/net/httpclient/AsyncExecutorShutdown.java fails in AssertionError due to misplaced assert
  • 361b50e: 8292594: Use CSS custom properties for all fonts and colors
  • 42b60ed: 8297030: Reduce Default Keep-Alive Timeout Value for httpclient
  • 1301fb0: 8296470: Refactor VMError::report STEP macro to improve readability
  • 48017b1: 8296804: Document HttpClient configuration properties in java.net.http module-info
  • ... and 23 more: https://git.openjdk.org/jdk/compare/50f9043c6965360c426b187e47c49c42481a2549...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2022

Going to push as commit 0edb5d0.
Since your change was applied there have been 127 commits pushed to the master branch:

  • c67166f: 8298003: NMT: fatal block printout does not show the correct corruption address
  • 99e2ef4: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java
  • 6065516: 8291418: adjust monitor deflation logging and deflate_idle_monitors use
  • 6e54705: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest
  • 562bc17: 8291359: Specification of method j.l.foreign.VaList::skip still deserves clarification
  • 2821fa9: 8280798: com.sun.jdi.ObjectReference::setValue spec should prohibit any final field modification
  • fb6fd03: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
  • 1b92465: 8297608: JFR: Incorrect duration after chunk rotation
  • 6065696: 8297982: Exclude vmTestbase/nsk/monitoring/stress/lowmem/ with ZGC until 8297979 is fixed
  • 415cfd2: 8297285: Shenandoah pacing causes assertion failure during VM initialization
  • ... and 117 more: https://git.openjdk.org/jdk/compare/50f9043c6965360c426b187e47c49c42481a2549...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2022
@openjdk openjdk bot closed this Dec 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2022
@openjdk
Copy link

openjdk bot commented Dec 4, 2022

@turbanoff Pushed as commit 0edb5d0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
2 participants