New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni #11385
Conversation
/contributor add mernst |
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran |
@jaikiran The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 7 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@@ -64,7 +64,7 @@ | |||
* By default an <b>asynchronously signalling Publisher</b> is provided, which will use {@link #createElement(int)} | |||
* to generate elements type your Subscriber is able to consume. | |||
* <p> | |||
* Sometimes you may want to implement your own custom custom helper Publisher - to validate behaviour of a Subscriber | |||
* Sometimes you may want to implement your own custom helper Publisher - to validate behaviour of a Subscriber |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment on the original PR is that this is a 3rd party code and not clear if it should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Alan, I have now updated this PR to remove changes to this file.
Thank you everyone for the reviews. |
/integrate |
Going to push as commit 0ce1827.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which fixes the typos in the test packages? @mernst submitted this as a separate PR #10029 but given the number of areas and files that other PR touches, the progress has been stalled.
I'll raise separate PRs in the other remaining areas from that other PR.
Progress
Issue
Reviewers
Contributors
<mernst@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11385/head:pull/11385
$ git checkout pull/11385
Update a local copy of the PR:
$ git checkout pull/11385
$ git pull https://git.openjdk.org/jdk pull/11385/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11385
View PR using the GUI difftool:
$ git pr show -t 11385
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11385.diff