Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni #11385

Closed
wants to merge 2 commits into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Nov 28, 2022

Can I please get a review of this change which fixes the typos in the test packages? @mernst submitted this as a separate PR #10029 but given the number of areas and files that other PR touches, the progress has been stalled.

I'll raise separate PRs in the other remaining areas from that other PR.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni

Reviewers

Contributors

  • Michael Ernst <mernst@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11385/head:pull/11385
$ git checkout pull/11385

Update a local copy of the PR:
$ git checkout pull/11385
$ git pull https://git.openjdk.org/jdk pull/11385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11385

View PR using the GUI difftool:
$ git pr show -t 11385

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11385.diff

@jaikiran
Copy link
Member Author

/contributor add mernst

@jaikiran jaikiran mentioned this pull request Nov 28, 2022
3 tasks
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2022

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@jaikiran
Contributor Michael Ernst <mernst@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@jaikiran The following labels will be automatically applied to this pull request:

  • core-libs
  • net
  • nio
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org nio nio-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org labels Nov 28, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni

Co-authored-by: Michael Ernst <mernst@openjdk.org>
Reviewed-by: alanb, lancea, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • ba0a252: 8297717: Remove jdk/internal/misc/TerminatingThreadLocal/TestTerminatingThreadLocal.java from ProblemList
  • c05dc80: 8297660: x86: Redundant test+jump in C1 allocateArray
  • eff4c03: 8297343: TestStress*.java fail with "got different traces for the same seed"
  • 6a856bc: 8297499: Parallel: Missing iteration over klass when marking objArrays/objArrayOops during Full GC
  • b80f5af: 8297309: Memory leak in ShenandoahFullGC
  • 81eb5fb: 8297534: Specify the size of MEMFLAGS
  • 012dafe: 8297082: Remove sun/tools/jhsdb/BasicLauncherTest.java from problem list

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2022
@@ -64,7 +64,7 @@
* By default an <b>asynchronously signalling Publisher</b> is provided, which will use {@link #createElement(int)}
* to generate elements type your Subscriber is able to consume.
* <p>
* Sometimes you may want to implement your own custom custom helper Publisher - to validate behaviour of a Subscriber
* Sometimes you may want to implement your own custom helper Publisher - to validate behaviour of a Subscriber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment on the original PR is that this is a 3rd party code and not clear if it should be changed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Alan, I have now updated this PR to remove changes to this file.

@jaikiran
Copy link
Member Author

Thank you everyone for the reviews.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 0ce1827.
Since your change was applied there have been 38 commits pushed to the master branch:

  • e2d71c0: 8297481: Create a regression test for JDK-4424517
  • f4063a3: 8297210: Add a @sealedGraph tag to selected java.desktop classes
  • 2084451: 8078471: Backspace does not work in JFileChooser with GTK L&F
  • 7af6b4b: 8296012: jshell crashes on mismatched record pattern
  • ae5b1f7: 8297685: Typo in NullPointerException description specified by Locale.lookup
  • 3ce0042: 8297780: Problem list java/awt/Frame/RestoreToOppositeScreen/RestoreToOppositeScreen.java
  • b778cd5: 8295010: Reduce if required in EC limbs operations
  • 54e6d6a: 8293488: Add EOR3 backend rule for aarch64 SHA3 extension
  • 69ede5b: 8293177: Verify version numbers in legal files
  • cd6bebb: 8247645: ChaCha20 intrinsics
  • ... and 28 more: https://git.openjdk.org/jdk/compare/43d1173605128126dda0dc39ffc376b84065cc65...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@jaikiran Pushed as commit 0ce1827.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated net net-dev@openjdk.org nio nio-dev@openjdk.org security security-dev@openjdk.org
4 participants