New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8297695: Fix typos in test/langtools files #11387
Conversation
/contributor add mernst |
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
@jaikiran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to jdk.javadoc test infrastructure look good to me.
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 37 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@jaikiran Many thanks for your help with this pull request. |
Thank you everyone for the reviews. |
/integrate |
Going to push as commit e10778a.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which fixes some typos in the
test/langtools
files? This was originally raised by @mernst in #10029, but given that the other PR touches multiple other areas and files, progress was stalled.The commit in this PR only fixes the typos in
test/langtools
files.Progress
Issue
Reviewers
Contributors
<mernst@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11387/head:pull/11387
$ git checkout pull/11387
Update a local copy of the PR:
$ git checkout pull/11387
$ git pull https://git.openjdk.org/jdk pull/11387/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11387
View PR using the GUI difftool:
$ git pr show -t 11387
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11387.diff