Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297736: test/jdk/java/foreign/TestMatrix.java is broken #11398

Closed
wants to merge 1 commit into from

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Nov 28, 2022

  • Fix tests that try to run TestDowncall which was split into TestDowncallScope and TestDowncallStack
  • Fix use of obsolete system properties to control specilization
  • Add test to run TestVarArgs in un-sampled mode.

Testing: Manual runs of TestMatrix.java (it's a manual test) on Windows and Linux (WSL).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8297736: test/jdk/java/foreign/TestMatrix.java is broken
  • JDK-8291642: java/foreign/TestMatrix.java -few tests are failing due to JDK-8287158.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11398/head:pull/11398
$ git checkout pull/11398

Update a local copy of the PR:
$ git checkout pull/11398
$ git pull https://git.openjdk.org/jdk pull/11398/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11398

View PR using the GUI difftool:
$ git pr show -t 11398

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11398.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2022

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@JornVernee JornVernee changed the title 8297736: TestMatrix is broken 8297736: test/jdk/java/foreign/TestMatrix.java is broken Nov 28, 2022
@openjdk
Copy link

openjdk bot commented Nov 28, 2022

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 28, 2022
@JornVernee JornVernee marked this pull request as ready for review November 29, 2022 13:44
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 29, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 29, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297736: test/jdk/java/foreign/TestMatrix.java is broken
8291642: java/foreign/TestMatrix.java -few tests are failing due to JDK-8287158.

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • c685569: 8297731: Remove redundant check in MutableBigInteger.divide
  • dcf431d: 8287400: Make BitMap range parameter names consistent
  • a1f4db5: 8297584: G1 parallel phase event for scan heap roots is sent too often
  • be4245e: 8294924: JvmtiExport::post_exception_throw() doesn't deal well with concurrent stack processing
  • be99e84: 8296875: Generational ZGC: Refactor loom code
  • 301cf52: 8297284: ResolutionErrorTable's key is wrong
  • a97e7d9: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live"
  • 4d730f5: 8297644: RISC-V: Compilation error when shenandoah is disabled
  • 27b339d: 8297523: Various GetPrimitiveArrayCritical miss result - NULL check
  • 3f8882b: 8297693: Fix typos in src/hotspot and test/hotspot files
  • ... and 42 more: https://git.openjdk.org/jdk/compare/105d9d75e84a46400f52fafda2ea00c99c14eaf0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 29, 2022
@JornVernee
Copy link
Member Author

/solves 8291642

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@JornVernee
Adding additional issue to solves list: 8291642: java/foreign/TestMatrix.java -few tests are failing due to JDK-8287158..

@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

Going to push as commit 1a2ff58.
Since your change was applied there have been 55 commits pushed to the master branch:

  • 6bac332: 8297853: windows-x86 test build broken
  • 53dd214: 8297742: Combine vmTestbase/nsk/monitoring/ThreadMXBean/resetPeakThreadCount tests
  • 1323e98: 8297170: misc JCK tests fail with "FATAL ERROR in native method: JDWP Can't disable vthread end events, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"
  • c685569: 8297731: Remove redundant check in MutableBigInteger.divide
  • dcf431d: 8287400: Make BitMap range parameter names consistent
  • a1f4db5: 8297584: G1 parallel phase event for scan heap roots is sent too often
  • be4245e: 8294924: JvmtiExport::post_exception_throw() doesn't deal well with concurrent stack processing
  • be99e84: 8296875: Generational ZGC: Refactor loom code
  • 301cf52: 8297284: ResolutionErrorTable's key is wrong
  • a97e7d9: 8297740: runtime/ClassUnload/UnloadTest.java failed with "Test failed: should still be live"
  • ... and 45 more: https://git.openjdk.org/jdk/compare/105d9d75e84a46400f52fafda2ea00c99c14eaf0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 30, 2022
@openjdk openjdk bot closed this Nov 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@JornVernee Pushed as commit 1a2ff58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants