8291359: Specification of method j.l.foreign.VaList::skip still deserves clarification

[JornVernee]

A small clarification of the VaList spec to say that attempts to access elements through an incorrect memory layout result in undefined behavior.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8291359: Specification of method j.l.foreign.VaList::skip still deserves clarification
• JDK-8297873: Specification of method j.l.foreign.VaList::skip still deserves clarification (CSR)

Reviewers

• Maurizio Cimadamore (@mcimadamore - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11440/head:pull/11440
$ git checkout pull/11440

Update a local copy of the PR:
$ git checkout pull/11440
$ git pull https://git.openjdk.org/jdk pull/11440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11440

View PR using the GUI difftool:
$ git pr show -t 11440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11440.diff

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JornVernee The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 05: Full - Incremental (95cac667)
• 04: Full - Incremental (ba3e977e)
• 03: Full - Incremental (a0648062)
• 02: Full - Incremental (6b2f059d)
• 01: Full - Incremental (79590943)
• 00: Full (4ec1cf54)

[openjdk]

@JornVernee Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291359: Specification of method j.l.foreign.VaList::skip still deserves clarification

Reviewed-by: mcimadamore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

• 2821fa9: 8280798: com.sun.jdi.ObjectReference::setValue spec should prohibit any final field modification
• fb6fd03: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
• 1b92465: 8297608: JFR: Incorrect duration after chunk rotation
• 6065696: 8297982: Exclude vmTestbase/nsk/monitoring/stress/lowmem/ with ZGC until 8297979 is fixed
• 415cfd2: 8297285: Shenandoah pacing causes assertion failure during VM initialization
• df07255: 8297984: Turn on warnings as errors for javadoc
• 227364d: 8297953: Fix several C2 IR matching tests for RISC-V
• 1370228: 8297941: Add override modifier in space.hpp
• 319faa5: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM
• b73363f: 8297686: JFR: Improve documentation of EventStream::onMetadata(Consumer)
• ... and 79 more: https://git.openjdk.org/jdk/compare/69ede5baeda6645aa3e961a02cbd40db965fc6a1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[JornVernee]

/integrate

[openjdk]

Going to push as commit 562bc17.
Since your change was applied there have been 89 commits pushed to the master branch:

• 2821fa9: 8280798: com.sun.jdi.ObjectReference::setValue spec should prohibit any final field modification
• fb6fd03: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero
• 1b92465: 8297608: JFR: Incorrect duration after chunk rotation
• 6065696: 8297982: Exclude vmTestbase/nsk/monitoring/stress/lowmem/ with ZGC until 8297979 is fixed
• 415cfd2: 8297285: Shenandoah pacing causes assertion failure during VM initialization
• df07255: 8297984: Turn on warnings as errors for javadoc
• 227364d: 8297953: Fix several C2 IR matching tests for RISC-V
• 1370228: 8297941: Add override modifier in space.hpp
• 319faa5: 8296084: javax/swing/JSpinner/4788637/bug4788637.java fails intermittently on a VM
• b73363f: 8297686: JFR: Improve documentation of EventStream::onMetadata(Consumer)
• ... and 79 more: https://git.openjdk.org/jdk/compare/69ede5baeda6645aa3e961a02cbd40db965fc6a1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee Pushed as commit 562bc17.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.