New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298027: Remove SCCS id's from awt jtreg tests #11509
Conversation
👋 Welcome back jdv! A progress list of the required criteria for merging this PR into |
@jayathirthrao The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
@jayathirthrao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit ba2d28e.
Your commit was automatically rebased without conflicts. |
@jayathirthrao Pushed as commit ba2d28e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Mailing list message from Patrick Chen on client-libs-dev: the last 12 years ? Le lun. 5 d?c. 2022 ? 16:39, Alexey Ivanov <aivanov at openjdk.org> a ?crit : -------------- next part -------------- |
Noticed SCCS jtreg id's in 2 open awt tests. After jtreg 7.1 update, jtreg doesn't parse SCCS id's and it causes the tests with SCCS id's to fail.
As of now these 2 tests are ignored, but it is good to remove these SCCS id's.
If we don't need these 2 tests since they are ignored, then i will update the PR base on the review comments.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11509/head:pull/11509
$ git checkout pull/11509
Update a local copy of the PR:
$ git checkout pull/11509
$ git pull https://git.openjdk.org/jdk pull/11509/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11509
View PR using the GUI difftool:
$ git pr show -t 11509
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11509.diff