Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298027: Remove SCCS id's from awt jtreg tests #11509

Closed
wants to merge 1 commit into from

Conversation

jayathirthrao
Copy link
Member

@jayathirthrao jayathirthrao commented Dec 5, 2022

Noticed SCCS jtreg id's in 2 open awt tests. After jtreg 7.1 update, jtreg doesn't parse SCCS id's and it causes the tests with SCCS id's to fail.

As of now these 2 tests are ignored, but it is good to remove these SCCS id's.
If we don't need these 2 tests since they are ignored, then i will update the PR base on the review comments.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11509/head:pull/11509
$ git checkout pull/11509

Update a local copy of the PR:
$ git checkout pull/11509
$ git pull https://git.openjdk.org/jdk pull/11509/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11509

View PR using the GUI difftool:
$ git pr show -t 11509

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11509.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2022

👋 Welcome back jdv! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@jayathirthrao The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 5, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 5, 2022

@jayathirthrao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298027: Remove SCCS id's from awt jtreg tests

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • a38c63d: 8297733: Refactor Cast binding to enum
  • 19d8498: 8297495: j.u.concurrent updates for JDK 20
  • 3288459: 8297606: [AIX] Broken build after JDK-8295475
  • 0452c39: 8296477: Foreign linker implementation update following JEP 434
  • 73baadc: 8295044: Implementation of Foreign Function and Memory API (Second Preview)
  • bd38188: 8297766: Remove UseMallocOnly development option
  • b9eec96: 8281214: Unsafe use of long in VMThread::setup_periodic_safepoint_if_needed
  • e7e0354: 8297767: Assert JNICritical_lock/safepoint-1 and AdapterHandlerLibrary_lock/safepoint-1
  • f9e0f1d: 8297763: Fix missing stub code expansion before align() in shared trampolines
  • 2300ed4: 8291769: Translation of switch with record patterns could be improved
  • ... and 2 more: https://git.openjdk.org/jdk/compare/d523d9d081a3bc698abcf493e038779a29eb47ea...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 5, 2022
@jayathirthrao
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2022

Going to push as commit ba2d28e.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 8d8a28f: 8296489: tools/jpackage/windows/WinL10nTest.java fails with timeout
  • 884b9ad: 8293453: tools/jpackage/share/AddLShortcutTest.java "Failed: Check the number of mismatched pixels [1024] of [1024] is < [0.100000] threshold"
  • 8af6e8a: 8298123: Problem List MaximizedToIconified.java on macOS
  • da0917a: 8297729: Replace GrowableArray in ComputeMoveOrder with hash table
  • 9827b75: 8298043: jdk/jfr/api/consumer/recordingstream/TestStop.java failed with "Expected outer stream to have 3 events"
  • 7d20a60: 8297489: Modify TextAreaTextEventTest.java as to verify the content change of TextComponent sends TextEvent
  • 601264d: 8273357: SecurityManager deprecation warning from java/awt/regtesthelpers/Util.java
  • 6a7a0db: 8296619: Upgrade jQuery to 3.6.1
  • a38c63d: 8297733: Refactor Cast binding to enum
  • 19d8498: 8297495: j.u.concurrent updates for JDK 20
  • ... and 10 more: https://git.openjdk.org/jdk/compare/d523d9d081a3bc698abcf493e038779a29eb47ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2022
@openjdk openjdk bot closed this Dec 6, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2022
@openjdk
Copy link

openjdk bot commented Dec 6, 2022

@jayathirthrao Pushed as commit ba2d28e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jayathirthrao jayathirthrao deleted the JDK-8298027 branch December 6, 2022 03:52
@mlbridge
Copy link

mlbridge bot commented Dec 6, 2022

Mailing list message from Patrick Chen on client-libs-dev:

the last 12 years ?

Le lun. 5 d?c. 2022 ? 16:39, Alexey Ivanov <aivanov at openjdk.org> a ?crit :

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/client-libs-dev/attachments/20221205/e27817d8/attachment.htm>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants