New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298177: Various java.lang.invoke cleanups #11540
Conversation
👋 Welcome back redestad! A progress list of the required criteria for merging this PR into |
Webrevs
|
@@ -607,7 +575,7 @@ public MemberName(Method m, boolean wantSpecial) { | |||
} | |||
throw new LinkageError(m.toString()); | |||
} | |||
assert(isResolved() && this.clazz != null); | |||
assert(isResolved()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why this can be removed. Can you explain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the if (clazz == null)
block above either returns or throws an error, so intellij was marking this as always true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see. Thanks
/solves 8284363 |
@cl4es |
@cl4es This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 26 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Ran through tier1+2 and all java.lang.invoke tests locally without surprises /integrate |
Going to push as commit 3de7750.
Your commit was automatically rebased without conflicts. |
Various code cleanups around java.lang.invoke code. Started out with dead code removal in
jli.MemberName
, then piled on to fix a set of minor inefficiencies (excessive vararg array allocations, unnecessary defensive cloning of parameter arrays etc).Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11540/head:pull/11540
$ git checkout pull/11540
Update a local copy of the PR:
$ git checkout pull/11540
$ git pull https://git.openjdk.org/jdk pull/11540/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11540
View PR using the GUI difftool:
$ git pr show -t 11540
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11540.diff