8298184: Incorrect record component type in record patterns

[lahodaj]

When a type of a record type is a generic type with wildcards, per specification[1] we should do upward projection on the component type. But the current code removes wildcards. As a consequence, for record type e.g. Box<? super String> the type of the record component is determined to be String, instead of Object, and as a consequence code like this:

    int runIfSuperBound(I<? super String> b) {
        if (b instanceof Box(var v)) return 1;
        return -1;
    }

will return -1 for new Box<>(new StringBuilder()).

The proposed fix is to use upward projections as per specification to compute the type of the record components.

[1] http://cr.openjdk.java.net/~gbierman/jep432%2b433/jep432+433-20221115/specs/patterns-switch-record-patterns-jls.html#jls-14.30.1

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298184: Incorrect record component type in record patterns

Reviewers

• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11543/head:pull/11543
$ git checkout pull/11543

Update a local copy of the PR:
$ git checkout pull/11543
$ git pull https://git.openjdk.org/jdk pull/11543/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11543

View PR using the GUI difftool:
$ git pr show -t 11543

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11543.diff

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (91ab056c)

[vicente-romero-oracle]

looks sensible

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298184: Incorrect record component type in record patterns

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 62baff5: 8298221: Problem list gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java on macosx-aarch64
• 16a5901: 8298214: ProblemList java/util/concurrent/forkjoin/AsyncShutdownNow.java
• b4da0ee: 8296507: GCM using more memory than necessary with in-place operations
• cd2182a: 8295724: VirtualMachineError: Out of space in CodeCache for method handle intrinsic
• 2cdc019: 8298178: Update to use jtreg 7.1.1
• 79d163d: 8293412: Remove unnecessary java.security.egd overrides
• ea83cb9: 8297450: ScaledTextFieldBorderTest.java fails when run with -show parameter
• 336d230: 8297958: NMT: Display peak values
• 0d2a9ee: 8298142: Update internal comment on language features in SourceVersion
• 203251f: 8297379: Enable the ByteBuffer path of Poly1305 optimizations
• ... and 9 more: https://git.openjdk.org/jdk/compare/923c746650204e36053251c19cf91b7e41e938b0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit cf63f2e.
Since your change was applied there have been 33 commits pushed to the master branch:

• 58170f6: 8298035: Provide better descriptions for JIT compiler JFR events
• bfcc238: 8297964: Jetty.java fails "assert(_no_handle_mark_nesting == 0) failed: allocating handle inside NoHandleMark"
• 3e041eb: 8298248: Limit sscanf output width in cgroup file parsers
• 4da8411: 8298108: Add a regression test for JDK-8297684
• 80cbfab: 8298169: Remove unused methods in space.hpp
• 221e1a4: 8286666: JEP 429: Implementation of Scoped Values (Incubator)
• ccc69af: 8296672: Implementation of Virtual Threads (Second Preview)
• 5a3439d: 4677581: ColorModel.getComponentSize()-wrong conditions for ArrayIndexOutOfBoundsExceptio
• 27bbe7b: 8297976: Remove sun.net.ProgressMonitor and related classes
• 085f96c: 8295258: Add BasicType argument to AccessInternal::decorator_fixup
• ... and 23 more: https://git.openjdk.org/jdk/compare/923c746650204e36053251c19cf91b7e41e938b0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit cf63f2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.