Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298274: Problem list TestSPISigned on Windows #11560

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 7, 2022

The test is failing on Windows. Problem list it until it can get properly analyzed and fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11560/head:pull/11560
$ git checkout pull/11560

Update a local copy of the PR:
$ git checkout pull/11560
$ git pull https://git.openjdk.org/jdk pull/11560/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11560

View PR using the GUI difftool:
$ git pr show -t 11560

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11560.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2022
@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 7, 2022

/label security-dev

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@jerboaa To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk openjdk bot added the security security-dev@openjdk.org label Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@jerboaa
The security label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 7, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298274: Problem list TestSPISigned on Windows

Reviewed-by: mullan, dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 3de7750: 8298177: Various java.lang.invoke cleanups
  • 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2022
Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up. This is a trivial fix.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 7, 2022

If somebody could test that the problem list entry works as expected on Windows, I'd appreciate it (I'm not touching those files much). Happy to integrate anytime, fwiw.

@dcubed-ojdk
Copy link
Member

Your ProblemList entry is properly formed. Please go ahead and integrate.

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 7, 2022

OK.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 7, 2022

Going to push as commit 29f1c3c.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 3de7750: 8298177: Various java.lang.invoke cleanups
  • 6ed3683: 8297209: Serial: Refactor GenCollectedHeap::full_process_roots

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 7, 2022
@openjdk openjdk bot closed this Dec 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 7, 2022
@openjdk
Copy link

openjdk bot commented Dec 7, 2022

@jerboaa Pushed as commit 29f1c3c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
3 participants