8298320: Typo in the comment block of catch_inline_exception

[navyxliu]

The following comment makes reference to 'Deutsch-Shiffman'. I believe it's a typo. It should be 'Schiffman' if the author intent to cite this paper:

Deutsch, L. Peter, and Allan M. Schiffman. "Efficient implementation of the Smalltalk-80 system." Proceedings of the 11th ACM SIGACT-SIGPLAN symposium on Principles of programming languages. 1984.

I ask 'Deutsch-Shiffman' to google and this is what google answers me. seems reasonable.

// Case 2: we have some handlers, with loaded exception klasses that have
// no subklasses. We do a Deutsch-Shiffman style type-check on the incoming
// exception oop and branch to the handler directly.
...
void Parse::catch_inline_exceptions(SafePointNode* ex_map) { 

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298320: Typo in the comment block of catch_inline_exception

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11598/head:pull/11598
$ git checkout pull/11598

Update a local copy of the PR:
$ git checkout pull/11598
$ git pull https://git.openjdk.org/jdk pull/11598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11598

View PR using the GUI difftool:
$ git pr show -t 11598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11598.diff

[bridgekeeper]

👋 Welcome back xliu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@navyxliu The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (6e49fde7)

[TobiHartmann]

Looks good and trivial.

[openjdk]

@navyxliu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298320: Typo in the comment block of  catch_inline_exception

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• cb766c5: 8297778: Modernize and improve module jdk.sctp
• 11aece2: 8257197: Add additional verification code to PhaseCCP
• 7f9c6ce: 8297679: InvocationTargetException field named target is not declared final
• 5540a8c: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
• c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
• 3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
• d35e840: 8297295: Remove ThreadGroup.allowThreadSuspension

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[navyxliu]

/integrate

[openjdk]

Going to push as commit 9346535.
Since your change was applied there have been 11 commits pushed to the master branch:

• b30b464: 8297036: Generalize C2 stub mechanism
• 05b0a01: 8298281: Serial: Refactor MarkAndPushClosure
• e3c6cf8: 8298380: Clean up redundant array length checks in JDK code base
• 33d955a: 8298345: Fix another two C2 IR matching tests for RISC-V
• cb766c5: 8297778: Modernize and improve module jdk.sctp
• 11aece2: 8257197: Add additional verification code to PhaseCCP
• 7f9c6ce: 8297679: InvocationTargetException field named target is not declared final
• 5540a8c: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
• c16eb89: 8298138: Shenandoah: HdrSeq asserts "sub-bucket index (512) overflow for value ( 1.00)"
• 3dfadee: 8292289: [vectorapi] Improve the implementation of VectorTestNode
• ... and 1 more: https://git.openjdk.org/jdk/compare/175e3d3ff332be25cca9822c58c46f1e012953c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@navyxliu Pushed as commit 9346535.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.