Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298521: Rename members in G1MonitoringSupport #11623

Closed
wants to merge 1 commit into from

Conversation

linade
Copy link
Contributor

@linade linade commented Dec 10, 2022

Hi,

Can I have review on this trivial change that renames a few members in G1MonitoringSupport for consistency?

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11623/head:pull/11623
$ git checkout pull/11623

Update a local copy of the PR:
$ git checkout pull/11623
$ git pull https://git.openjdk.org/jdk pull/11623/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11623

View PR using the GUI difftool:
$ git pr show -t 11623

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11623.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 10, 2022

👋 Welcome back linade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 10, 2022
@openjdk
Copy link

openjdk bot commented Dec 10, 2022

@linade The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 10, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 10, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 12, 2022

@linade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298521: Rename members in G1MonitoringSupport

Reviewed-by: ayang, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 3b1142a: 8298618: Typo in JPEGImageReader and JPEGImageWriter
  • 173778e: 8298568: Fastdebug build fails after JDK-8296389
  • 829cbc2: 8292674: ReportJNIFatalError should print all java frames
  • be69930: 8288287: Remove expired flags in JDK 21
  • c3bc4fc: 8297505: Declare fields in some sun.security.pkcs11 classes as final
  • c7aca73: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())
  • 781a2e0: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug
  • 9ff85f6: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil
  • 81f57d5: 8298567: Make field in RandomAccessFile final
  • 56c438b: 8297822: De-duplicate code in module jdk.sctp
  • ... and 5 more: https://git.openjdk.org/jdk/compare/8ea2a6777b68986df9d191f1bf983549d72cb3f8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@albertnetymk, @tschatzl) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2022
@linade
Copy link
Contributor Author

linade commented Dec 13, 2022

/integrate

Thank you @albertnetymk . Are you able to sponsor this change : )

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@linade
Your change (at version 178cc3b) is now ready to be sponsored by a Committer.

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@tschatzl
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

Going to push as commit dbcfe7b.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 3b1142a: 8298618: Typo in JPEGImageReader and JPEGImageWriter
  • 173778e: 8298568: Fastdebug build fails after JDK-8296389
  • 829cbc2: 8292674: ReportJNIFatalError should print all java frames
  • be69930: 8288287: Remove expired flags in JDK 21
  • c3bc4fc: 8297505: Declare fields in some sun.security.pkcs11 classes as final
  • c7aca73: 8295857: Clarify that cleanup code can be skipped when the JVM terminates (e.g. when calling halt())
  • 781a2e0: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug
  • 9ff85f6: 8298589: java/net/SctpSanity.java fail with NoClassDefFoundError: sun/nio/ch/sctp/UnsupportedUtil
  • 81f57d5: 8298567: Make field in RandomAccessFile final
  • 56c438b: 8297822: De-duplicate code in module jdk.sctp
  • ... and 5 more: https://git.openjdk.org/jdk/compare/8ea2a6777b68986df9d191f1bf983549d72cb3f8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2022
@openjdk openjdk bot closed this Dec 13, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@tschatzl @linade Pushed as commit dbcfe7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants