Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298692: Fix typos in test/jdk/com/sun/jdi files #11656

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 13, 2022

These are the typos from #10029 that relate to test/jdk/com/sun/jdi.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11656/head:pull/11656
$ git checkout pull/11656

Update a local copy of the PR:
$ git checkout pull/11656
$ git pull https://git.openjdk.org/jdk pull/11656/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11656

View PR using the GUI difftool:
$ git pr show -t 11656

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11656.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298692 8298692: Fix typos in test/jdk/com/sun/jdi files Dec 13, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 13, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298692: Fix typos in test/jdk/com/sun/jdi files

Reviewed-by: amenkov, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • a120764: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker
  • 6802277: 8298524: Debug function to trace reachability of CDS archived heap objects

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 13, 2022
Copy link
Contributor

@sspitsyn sspitsyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks,
Serguei

@plummercj
Copy link
Contributor Author

Thanks Alex and Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

Going to push as commit 7241e35.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 736fcd4: 8296318: use-def assert: special case undetected loops nested in infinite loops
  • c05dbac: 8193547: Regression automated test '/open/test/jdk/java/awt/Toolkit/DesktopProperties/rfe4758438.java' fails
  • 0dce5b8: 8296610: java/net/HttpURLConnection/SetAuthenticator/HTTPSetAuthenticatorTest.java failed with "BindException: Address already in use: connect"
  • ed8a212: 8298376: ZGC: thaws stackChunk with stale oops
  • 2e801e1: 8298475: Remove JVM_ACC_PROMOTED_FLAGS
  • 9ee5037: 8298636: Fix return value in WB_CountAliveClasses and WB_GetSymbolRefcount
  • ceca4fc: 8298264: Merge OffsetTableContigSpace into TenuredSpace
  • d32d6c0: 8297791: update _max_classes in node type system
  • b754aa5: 8298371: monitors_on_stack extracts unprocessed oops
  • 220781f: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker
  • ... and 2 more: https://git.openjdk.org/jdk/compare/23e18275ac2a7297ba806a1835fabb7141949967...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 14, 2022
@openjdk openjdk bot closed this Dec 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@plummercj Pushed as commit 7241e35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants