New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298701: Cleanup SA entries in ProblemList-zgc.txt. #11658
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label serviceability |
@plummercj |
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 116 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Can I get a second review please? Thanks! |
Thanks for the reviews Alex and Serguei! /integrate |
Going to push as commit 9194e91.
Your commit was automatically rebased without conflicts. |
@plummercj Pushed as commit 9194e91. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The following ProblemList-zgc.txt entries need a lot of cleanup.
serviceability/sa/ClhsdbCDSCore.java 8268722 macosx-x64
serviceability/sa/ClhsdbFindPC.java#xcomp-core 8268722,8284045 macosx-x64,generic-all
serviceability/sa/ClhsdbFindPC.java#no-xcomp-core 8268722 macosx-x64
serviceability/sa/ClhsdbFindPC.java#xcomp-process 8276402 generic-all
serviceability/sa/ClhsdbJstack.java#id0 8276402 generic-all
serviceability/sa/ClhsdbPmap.java#core 8268722 macosx-x64
serviceability/sa/ClhsdbPstack.java#core 8268722 macosx-x64
serviceability/sa/TestJmapCore.java 8268722,8268283,8270202 macosx-x64,linux-aarch64,linux-x64
serviceability/sa/TestJmapCoreMetaspace.java 8268722,8268636 generic-all
JDK-8268722 entries can be removed. It was closed as WNF. It doesn't really impact macosx-aarch64 (core files are reasonably small there), and on macosx-x64 all these core file tests are (probably indefinitely) problem listed for other reasons in the main problem list, so no need to problem list them here with a closed CR.
JDK-8276402 has been closed as dup of a bug that is now fixed.
Lastly, TestJmapCore.java does fail on macosx-aarch64 due to JDK-8268283, so its problem list entry needs to be updated to reflect that.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11658/head:pull/11658
$ git checkout pull/11658
Update a local copy of the PR:
$ git checkout pull/11658
$ git pull https://git.openjdk.org/jdk pull/11658/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11658
View PR using the GUI difftool:
$ git pr show -t 11658
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11658.diff