Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298701: Cleanup SA entries in ProblemList-zgc.txt. #11658

Closed
wants to merge 2 commits into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Dec 13, 2022

The following ProblemList-zgc.txt entries need a lot of cleanup.

serviceability/sa/ClhsdbCDSCore.java 8268722 macosx-x64
serviceability/sa/ClhsdbFindPC.java#xcomp-core 8268722,8284045 macosx-x64,generic-all
serviceability/sa/ClhsdbFindPC.java#no-xcomp-core 8268722 macosx-x64
serviceability/sa/ClhsdbFindPC.java#xcomp-process 8276402 generic-all
serviceability/sa/ClhsdbJstack.java#id0 8276402 generic-all
serviceability/sa/ClhsdbPmap.java#core 8268722 macosx-x64
serviceability/sa/ClhsdbPstack.java#core 8268722 macosx-x64
serviceability/sa/TestJmapCore.java 8268722,8268283,8270202 macosx-x64,linux-aarch64,linux-x64
serviceability/sa/TestJmapCoreMetaspace.java 8268722,8268636 generic-all

JDK-8268722 entries can be removed. It was closed as WNF. It doesn't really impact macosx-aarch64 (core files are reasonably small there), and on macosx-x64 all these core file tests are (probably indefinitely) problem listed for other reasons in the main problem list, so no need to problem list them here with a closed CR.

JDK-8276402 has been closed as dup of a bug that is now fixed.

Lastly, TestJmapCore.java does fail on macosx-aarch64 due to JDK-8268283, so its problem list entry needs to be updated to reflect that.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298701: Cleanup SA entries in ProblemList-zgc.txt.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11658/head:pull/11658
$ git checkout pull/11658

Update a local copy of the PR:
$ git checkout pull/11658
$ git pull https://git.openjdk.org/jdk pull/11658/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11658

View PR using the GUI difftool:
$ git pr show -t 11658

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11658.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2022

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8298701 8298701: Cleanup SA entries in ProblemList-zgc.txt. Dec 13, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2022
@openjdk
Copy link

openjdk bot commented Dec 13, 2022

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@plummercj
Copy link
Contributor Author

/label serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Dec 14, 2022
@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@plummercj
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298701: Cleanup SA entries in ProblemList-zgc.txt.

Reviewed-by: sspitsyn, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 116 new commits pushed to the master branch:

  • bfa921a: 8160404: RelocationHolder constructors have bugs
  • bf9a8ce: 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id
  • 0eeaeb8: 8298808: Check script code on detecting the base locales
  • 81e23ab: 8298809: Clean up vm/compiler/InterfaceCalls JMH
  • 3696711: Merge
  • f771c56: 8298797: Specification of some restricted methods is incorrect
  • 0ba4734: 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there.
  • c47e64e: 8297979: ZGC: Ensure consistent MemoryUsage from MemoryMXBean.getHeapMemoryUsage()
  • 03a694a: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
  • c7d7e7e: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
  • ... and 106 more: https://git.openjdk.org/jdk/compare/7f9c6ce3318aedfd85f12f4002dc442b0b468c27...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2022
@plummercj
Copy link
Contributor Author

Can I get a second review please? Thanks!

@plummercj
Copy link
Contributor Author

Thanks for the reviews Alex and Serguei!

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2022

Going to push as commit 9194e91.
Since your change was applied there have been 128 commits pushed to the master branch:

  • 4c927df: 8298470: Short cut java.lang.Object super class loading
  • 756a06d: 8299022: Linux ppc64le and s390x build issues after JDK-8160404
  • de0ce79: 8297801: printnm crashes with invalid address due to null pointer dereference
  • da38d43: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts
  • 8e49fcd: 8295661: CompileTask::compile_id() should be passed as int
  • 86d588b: 8283740: C1: Convert flag TwoOperandLIRForm to a constant on all platforms
  • ec95991: 8298736: Revisit usages of log10 in compiler code
  • 1622563: 8265688: Unused ciMethodType::ptype_at should be removed
  • 3637660: 8298813: [C2] Converting double to float cause a loss of precision and resulting crypto.aes scores fluctuate
  • 5e678f7: 8298824: C2 crash: assert(is_Bool()) failed: invalid node class: ConI
  • ... and 118 more: https://git.openjdk.org/jdk/compare/7f9c6ce3318aedfd85f12f4002dc442b0b468c27...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2022
@openjdk openjdk bot closed this Dec 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2022
@openjdk
Copy link

openjdk bot commented Dec 19, 2022

@plummercj Pushed as commit 9194e91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants