Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298808: Check script code on detecting the base locales #11684

Closed
wants to merge 2 commits into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Dec 14, 2022

Fixing CLDRConverter build tool to not regard new locales introduced in CLDR 43 as one of the base locales. Otherwise they would incorrectly go into java.base module, then a test case fails.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298808: Check script code on detecting the base locales

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11684/head:pull/11684
$ git checkout pull/11684

Update a local copy of the PR:
$ git checkout pull/11684
$ git pull https://git.openjdk.org/jdk pull/11684/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11684

View PR using the GUI difftool:
$ git pr show -t 11684

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11684.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 14, 2022

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Dec 14, 2022
@naotoj naotoj marked this pull request as ready for review December 14, 2022 23:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 14, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 14, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 15, 2022

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298808: Check `script` code on detecting the base locales

Reviewed-by: joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • f4caaca: 8298852: Use of uninitialized memory in MetadataFactory::free_metadata
  • ac2fcf3: 8296374: Check for young region in G1BarrierSet::invalidate instead of card-by-card check
  • 909d0cb: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
  • 226e579: 8298088: RISC-V: Make Address a discriminated union internally
  • fa322e4: 8298709: Fix typos in src/java.desktop/ and various test classes of client component
  • e41686b: 8298710: Fix typos in test/jdk/sun/security/tools/jarsigner/
  • a336461: 8298081: DiagnoseSyncOnValueBasedClasses doesn't report useful information for virtual threads
  • 2bb727c: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 5412439: 8298187: (fs) BsdFileAttributeViews::setTimes does not support lastAccessTime on HFS+
  • 3cdbd87: 8298241: Replace C-style casts with JavaThread::cast
  • ... and 43 more: https://git.openjdk.org/jdk/compare/23e18275ac2a7297ba806a1835fabb7141949967...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 15, 2022
@magicus
Copy link
Member

magicus commented Dec 16, 2022

/label -build

@openjdk openjdk bot removed the build build-dev@openjdk.org label Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@magicus
The build label was successfully removed.

@naotoj
Copy link
Member Author

naotoj commented Dec 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 16, 2022

Going to push as commit 0eeaeb8.
Since your change was applied there have been 65 commits pushed to the master branch:

  • 81e23ab: 8298809: Clean up vm/compiler/InterfaceCalls JMH
  • 3696711: Merge
  • f771c56: 8298797: Specification of some restricted methods is incorrect
  • 0ba4734: 8287699: jdk/jfr/api/consumer/TestRecordingFileWrite.java fails with exception: java.lang.Exception: Found event that should not be there.
  • c47e64e: 8297979: ZGC: Ensure consistent MemoryUsage from MemoryMXBean.getHeapMemoryUsage()
  • 03a694a: 8298083: The "CheckBox/RadioButton[Enabled/Disabled].textForeground" stoped working
  • c7d7e7e: 8298888: ProblemList gc/g1/TestVerifyGCType.java on linux and macosx
  • ca39eb9: 7093322: (fs spec) Files.newBufferedWriter should be clear when coding errors are detected
  • 2c42499: 8298050: Add links to graph output for javadoc
  • 48f6127: 8298376: ZGC: thaws stackChunk with stale oops
  • ... and 55 more: https://git.openjdk.org/jdk/compare/23e18275ac2a7297ba806a1835fabb7141949967...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2022
@openjdk openjdk bot closed this Dec 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 16, 2022
@openjdk
Copy link

openjdk bot commented Dec 16, 2022

@naotoj Pushed as commit 0eeaeb8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
3 participants