New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298808: Check script
code on detecting the base locales
#11684
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
Webrevs
|
@naotoj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 53 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/label -build |
@magicus |
/integrate |
Going to push as commit 0eeaeb8.
Your commit was automatically rebased without conflicts. |
Fixing
CLDRConverter
build tool to not regard new locales introduced in CLDR 43 as one of the base locales. Otherwise they would incorrectly go intojava.base
module, then a test case fails.Progress
Issue
script
code on detecting the base localesReviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11684/head:pull/11684
$ git checkout pull/11684
Update a local copy of the PR:
$ git checkout pull/11684
$ git pull https://git.openjdk.org/jdk pull/11684/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11684
View PR using the GUI difftool:
$ git pr show -t 11684
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11684.diff