8298736: Revisit usages of log10 in compiler code

[dafedafe]

The use of the Math library log10 function causes an overloading ambiguity error on SPARC when using it with integer typed parameters.

• adding a static_cast<double> to the parameter
• using the lib log10 function (with static_casts) instead of a custom one in src/hotspot/share/opto/node.cpp

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298736: Revisit usages of log10 in compiler code

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)
• Emanuel Peter (@eme64 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11686/head:pull/11686
$ git checkout pull/11686

Update a local copy of the PR:
$ git checkout pull/11686
$ git pull https://git.openjdk.org/jdk pull/11686/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11686

View PR using the GUI difftool:
$ git pr show -t 11686

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11686.diff

[bridgekeeper]

Hi @dafedafe, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user dafedafe" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@dafedafe The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[eme64]

Replacing my custom log10 with lib version looks good, we verified it manually.

[TobiHartmann]

Looks good to me too.

[openjdk]

@dafedafe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298736: Revisit usages of log10 in compiler code

Reviewed-by: thartmann, chagedorn, epeter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 1622563: 8265688: Unused ciMethodType::ptype_at should be removed
• 3637660: 8298813: [C2] Converting double to float cause a loss of precision and resulting crypto.aes scores fluctuate
• 5e678f7: 8298824: C2 crash: assert(is_Bool()) failed: invalid node class: ConI
• ba942c2: 8298244: AArch64: Optimize vector implementation of AddReduction for floating point
• 7938f8c: 8298639: Perform I/O operations in bulk for RandomAccessFile
• bfa921a: 8160404: RelocationHolder constructors have bugs
• bf9a8ce: 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id
• 0eeaeb8: 8298808: Check script code on detecting the base locales
• 81e23ab: 8298809: Clean up vm/compiler/InterfaceCalls JMH
• 3696711: Merge
• ... and 55 more: https://git.openjdk.org/jdk/compare/2e801e16ec40ce0e25d8679e21d7da347c52d7be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann, @chhagedorn, @eme64) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (b96a5b22)

[chhagedorn]

Looks good!

[eme64]

Looks good!

[dafedafe]

@TobiHartmann @chhagedorn @eme64 thanks for your reviews!

[dafedafe]

/integrate

[openjdk]

@dafedafe
Your change (at version b96a5b2) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit ec95991.
Since your change was applied there have been 65 commits pushed to the master branch:

• 1622563: 8265688: Unused ciMethodType::ptype_at should be removed
• 3637660: 8298813: [C2] Converting double to float cause a loss of precision and resulting crypto.aes scores fluctuate
• 5e678f7: 8298824: C2 crash: assert(is_Bool()) failed: invalid node class: ConI
• ba942c2: 8298244: AArch64: Optimize vector implementation of AddReduction for floating point
• 7938f8c: 8298639: Perform I/O operations in bulk for RandomAccessFile
• bfa921a: 8160404: RelocationHolder constructors have bugs
• bf9a8ce: 8249826: 5 javax/net/ssl/SSLEngine tests use @ignore w/o bug-id
• 0eeaeb8: 8298808: Check script code on detecting the base locales
• 81e23ab: 8298809: Clean up vm/compiler/InterfaceCalls JMH
• 3696711: Merge
• ... and 55 more: https://git.openjdk.org/jdk/compare/2e801e16ec40ce0e25d8679e21d7da347c52d7be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @dafedafe Pushed as commit ec95991.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.