8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

[afshin-zafari]

Description

The following problems found and solved:

1. Reporting which regex pattern did not match with error messages was incorrect. To report the mismatched pattern, the head of the pattern list was peeked, while it was the already peeked item from that did not match. So the next pattern to the mismatched one was reported.

2. The pattern for finding a crash was incorrectly set to "# .*VMError::controlled_crash.*", while it has to be "# .*crash_with_segfault.*".

3. crash_with_segfault function is too small and was inlined in compiler optimisations. So it was not in the stack trace when the error message is created.

Patch

1 and 2 corrected and added the NOINLINE to the crash_with_segfault signature. The same applied for crash_with_sigfpe function.

Test

runtime/ErrorHandling/* and tier1-5

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

Reviewers

• Daniel D. Daugherty (@dcubed-ojdk - Reviewer)
• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 430f0210
• Thomas Stuefe (@tstuefe - Reviewer) ⚠️ Review applies to 430f0210

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11704/head:pull/11704
$ git checkout pull/11704

Update a local copy of the PR:
$ git checkout pull/11704
$ git pull https://git.openjdk.org/jdk pull/11704/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11704

View PR using the GUI difftool:
$ git pr show -t 11704

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11704.diff

[bridgekeeper]

👋 Welcome back afshin-zafari! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@afshin-zafari The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (653b3739)
• 03: Full - Incremental (430f0210)
• 02: Full - Incremental (35e46757)
• 01: Full - Incremental (04a11f6b)
• 00: Full (0fc85607)

[robehn]

Seems good to me! Thanks!

[dcubed-ojdk]

Thumbs up. Thanks for the careful analysis and including
your testing information.

I've only posted nit comments about typos.

[openjdk]

@afshin-zafari This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298128: runtime/ErrorHandling/TestSigInfoInHsErrFile.java fails to find pattern with slowdebug

Reviewed-by: dcubed, dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 310 new commits pushed to the master branch:

• a2f6766: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• a734285: 8299879: CollectedHeap hierarchy should use override
• 98d75f1: 8299038: Add AArch64 backend support for auto-vectorized FP16 conversions
• cac72a6: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
• 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
• 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
• abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
• 83f2c9a: 8293410: Remove GenerateRangeChecks flag
• 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
• fe7fca0: 8300032: DwarfParser resource leak
• ... and 300 more: https://git.openjdk.org/jdk/compare/fa322e40b68abf0a253040d14414d41f4e01e028...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dcubed-ojdk, @dholmes-ora, @tstuefe) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[dcubed-ojdk]

Still thumbs up

[dholmes-ora]

The error was only occurring on a slow debug build, has the fix been tested on all builds?

Thanks.

[tstuefe]

@afshin-zafari, thank you for finding and fixing this.

I worry that this may be too fragile, since it depends on linker hints that AFAIK the linker could ignore. Could we instead match with something like "# .*(VMError::controlled_crash|crash_with).*"?

[afshin-zafari]

@afshin-zafari, thank you for finding and fixing this.

I worry that this may be too fragile, since it depends on linker hints that AFAIK the linker could ignore. Could we instead match with something like "# .*(VMError::controlled_crash|crash_with).*"?

ALWAYSINLINE or its expanded form __attribute__ (always_inline) will prevail all other compile options for inlining (particularly compiler optimisation options) , e.g. limit number and/or do or don't inlining. So it would not be ignored as was not in tier 1-5 tests.

[tstuefe]

@afshin-zafari, thank you for finding and fixing this.
I worry that this may be too fragile, since it depends on linker hints that AFAIK the linker could ignore. Could we instead match with something like "# .*(VMError::controlled_crash|crash_with).*"?

ALWAYSINLINE or its expanded form __attribute__ (always_inline) will prevail all other compile options for inlining (particularly compiler optimisation options) , e.g. limit number and/or do or don't inlining. So it would not be ignored as was not in tier 1-5 tests.

Okay, good enough then. Just wanted to prevent false positives (we had a lot of work when writing tests for NMT call stack matching).

+1

[dcubed-ojdk]

You need to backout the copyright year changes to the two test files that
are no longer modified by this patch.

[dholmes-ora]

Looks good modulo the copyright changes that need undoing. Thanks.

[afshin-zafari]

Copyright years are backed to 2022.

[dcubed-ojdk]

Thumbs up.

[afshin-zafari]

/integrate

[openjdk]

@afshin-zafari
Your change (at version 653b373) is now ready to be sponsored by a Committer.

[robehn]

/sponsor

[openjdk]

Going to push as commit 289aed4.
Since your change was applied there have been 310 commits pushed to the master branch:

• a2f6766: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• a734285: 8299879: CollectedHeap hierarchy should use override
• 98d75f1: 8299038: Add AArch64 backend support for auto-vectorized FP16 conversions
• cac72a6: 8300053: Shenandoah: Handle more GCCauses in ShenandoahControlThread::request_gc
• 6fea233: 8299960: Speed up test/hotspot/jtreg/compiler/c2/irTests/TestVectorizeURShiftSubword.java
• 7c1ebcc: 8299962: Speed up compiler/intrinsics/unsafe/DirectByteBufferTest.java and HeapByteBufferTest.java
• abfd7e8: 8300113: C2: Single-bit fields with signed type in TypePtr after JDK-8297933
• 83f2c9a: 8293410: Remove GenerateRangeChecks flag
• 50e7df9: 8300024: Replace use of JNI_COMMIT mode with mode 0
• fe7fca0: 8300032: DwarfParser resource leak
• ... and 300 more: https://git.openjdk.org/jdk/compare/fa322e40b68abf0a253040d14414d41f4e01e028...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn @afshin-zafari Pushed as commit 289aed4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.