8299044 : test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

[lawrence-andrew]

This test needs to be executed on mac os only

@shurymury
@honkar-jdk

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299044: test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)
• Harshitha Onkar (@honkar-jdk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11730/head:pull/11730
$ git checkout pull/11730

Update a local copy of the PR:
$ git checkout pull/11730
$ git pull https://git.openjdk.org/jdk pull/11730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11730

View PR using the GUI difftool:
$ git pr show -t 11730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11730.diff

[bridgekeeper]

👋 Welcome back lawrence-andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lawrence-andrew The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1fca643d)

[openjdk]

@lawrence-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299044: test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java fails on non mac

Reviewed-by: serb, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943
• 40cb431: 8298943: Missing escapes for single quote marks in compiler.properties

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb, @honkar-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[honkar-jdk]

@lawrence-andrew Since it is manual test, I think adding that it is as mac-only test to the instructions would provide more clarity.

[lawrence-andrew]

@honkar-jdk , exception is thrown before showing the instruction since the test tries to load the https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JComboBox/JComboBoxBorderTest.java#L86

[lawrence-andrew]

/integrate

[openjdk]

@lawrence-andrew
Your change (at version 1fca643) is now ready to be sponsored by a Committer.

[honkar-jdk]

/sponsor

[openjdk]

Going to push as commit abc1297.
Since your change was applied there have been 2 commits pushed to the master branch:

• 5d330f5: 8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943
• 40cb431: 8298943: Missing escapes for single quote marks in compiler.properties

Your commit was automatically rebased without conflicts.

[openjdk]

@honkar-jdk @lawrence-andrew Pushed as commit abc1297.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.