New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943 #11732
JDK-8299045: tools/doclint/BadPackageCommentTest.java fails after JDK-8298943 #11732
Conversation
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
@jonathan-gibbons The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5d330f5. |
@jonathan-gibbons Pushed as commit 5d330f5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Oops - my fault. Thanks for fixing. |
Please review a fix for the golden-file for a test, required after quotes in resources were fixed in JDK-8298943.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11732/head:pull/11732
$ git checkout pull/11732
Update a local copy of the PR:
$ git checkout pull/11732
$ git pull https://git.openjdk.org/jdk pull/11732/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11732
View PR using the GUI difftool:
$ git pr show -t 11732
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11732.diff