8299437: Make InetSocketAddressHolder shallowly immutable

[minborg]

This PR proposes to make the class java.net.InetSocketAddress.InetSocketAddressHolder shallowly immutable

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299437: Make InetSocketAddressHolder shallowly immutable

Reviewers

• Daniel Jeliński (@djelinski - Committer)
• Jaikiran Pai (@jaikiran - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11809/head:pull/11809
$ git checkout pull/11809

Update a local copy of the PR:
$ git checkout pull/11809
$ git pull https://git.openjdk.org/jdk pull/11809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11809

View PR using the GUI difftool:
$ git pr show -t 11809

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11809.diff

[bridgekeeper]

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@minborg The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (749890bb)

[jaikiran]

Looks fine to me.

[openjdk]

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299437: Make InetSocketAddressHolder shallowly immutable

Reviewed-by: djelinski, jpai, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• 3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
• 417d01e: 8299441: Fix typos in some test files under core-libs component
• 5b5552f: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
• 67086eb: 8299030: Refactor ReservedSpace::reserve
• ce6395a: 8299397: Remove metaprogramming/isFloatingPoint.hpp
• 71a64a1: 8299399: Remove metaprogramming/isArray.hpp
• 532ccdb: 8299396: Remove metaprogramming/removeExtent.hpp
• 9d3d039: 8299402: Remove metaprogramming/isVolatile.hpp
• c252a85: 8298652: G1: Refactor G1MarkAndPushClosure
• 8a10eef: 8299193: (bf) Buffer.capacity should be declared final
• ... and 5 more: https://git.openjdk.org/jdk/compare/2ee34f14880cccca02e2933f80b000979f33c6d1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@djelinski, @jaikiran, @AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[minborg]

/integrate

[openjdk]

@minborg
Your change (at version 749890b) is now ready to be sponsored by a Committer.

[AlanBateman]

Well spotted, I don't know why these fields weren't final from the start.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit a9ce772.
Since your change was applied there have been 16 commits pushed to the master branch:

• 8afd665: 8299395: Remove metaprogramming/removeCV.hpp
• 3757433: 8295974: jni_FatalError and Xcheck:jni warnings should print the native stack when there are no Java frames
• 417d01e: 8299441: Fix typos in some test files under core-libs component
• 5b5552f: 8299483: ProblemList java/text/Format/NumberFormat/CurrencyFormat.java
• 67086eb: 8299030: Refactor ReservedSpace::reserve
• ce6395a: 8299397: Remove metaprogramming/isFloatingPoint.hpp
• 71a64a1: 8299399: Remove metaprogramming/isArray.hpp
• 532ccdb: 8299396: Remove metaprogramming/removeExtent.hpp
• 9d3d039: 8299402: Remove metaprogramming/isVolatile.hpp
• c252a85: 8298652: G1: Refactor G1MarkAndPushClosure
• ... and 6 more: https://git.openjdk.org/jdk/compare/2ee34f14880cccca02e2933f80b000979f33c6d1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @minborg Pushed as commit a9ce772.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.