8299593: getprotobyname should not be used

[djelinski]

Please review this patch that removes the remaining uses of non-reentrant getprotobyname function.

While the protocol number for TCP could theoretically be modified to something other than the default IPPROTO_TCP, that scenario would likely not work, and is not something that we are willing to support. Existing code in networking area is using IPPROTO_TCP for TCP_NODELAY, and no issues were reported.

Tier 1-3 tests still pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8299593: getprotobyname should not be used

Reviewers

• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11842/head:pull/11842
$ git checkout pull/11842

Update a local copy of the PR:
$ git checkout pull/11842
$ git pull https://git.openjdk.org/jdk pull/11842/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11842

View PR using the GUI difftool:
$ git pr show -t 11842

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11842.diff

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (65f67237)

[AlanBateman]

Looks okay, should be no reason to use getprotobyname here. I assume everything would break if /etc/protocols were changed to set to another value.

[plummercj]

Looks good.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299593: getprotobyname should not be used

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 55 new commits pushed to the master branch:

• d086e82: 8299600: Use Objects.check*() where appropriate in java.io
• 4a95c74: 8299425: "LCMSImageLayout.isIntPacked" flag can be deleted
• d6d6eb4: 8299699: Test runtime/cds/appcds/WrongClasspath.java fails after JDK-8299329
• 8c70bf3: 8299544: Improve performance of CRC32C intrinsics (non-AVX-512) for small inputs
• d6e9f01: 8285416: [LOOM] Some nsk/jdi tests fail due to needing too many virtual threads
• ba03f42: 8299746: Accept unknown signatureAlgorithm in PKCS7 SignerInfo
• 3dcf700: 8299336: InputStream::DEFAULT_BUFFER_SIZE should be 16384
• 1e99729: 8299274: Add elements to resolved_references consistently
• 8cc1669: 8299721: [Vector API] assert in switch-default of LibraryCallKit::arch_supports_vector_rotate is too weak to catch bugs
• 5598acc: 8294403: [REDO] make test should report only on executed tests
• ... and 45 more: https://git.openjdk.org/jdk/compare/245f0cf4ac9dc655bfe2abb1c88c6ed1ddffd291...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[djelinski]

/integrate

[openjdk]

Going to push as commit d03a5d9.
Since your change was applied there have been 69 commits pushed to the master branch:

• c444922: 8218474: JComboBox display issue with GTKLookAndFeel
• 7607c07: 8299774: SYNTH_BUTTON_UI_KEY field is unused
• d53cac3: 8299481: Remove metaprogramming/removePointer.hpp
• 834e50e: 8298921: Create a regression test for JDK-8139581
• e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
• d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
• 63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
• 5393dc9: Merge
• 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
• 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
• ... and 59 more: https://git.openjdk.org/jdk/compare/245f0cf4ac9dc655bfe2abb1c88c6ed1ddffd291...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit d03a5d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.