Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary #11867

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 5, 2023

Trivial change of removing dead code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11867/head:pull/11867
$ git checkout pull/11867

Update a local copy of the PR:
$ git checkout pull/11867
$ git pull https://git.openjdk.org/jdk pull/11867/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11867

View PR using the GUI difftool:
$ git pr show -t 11867

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11867.diff

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8299692 8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary Jan 5, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 5, 2023
@openjdk
Copy link

openjdk bot commented Jan 5, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2023

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk
Copy link

openjdk bot commented Jan 7, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299692: G1: Remove unused G1BlockOffsetTable::is_card_boundary

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 30 new commits pushed to the master branch:

  • e209693: 8258776: ThreadLocal#initialValue() Javadoc is unaware of ThreadLocal#withInitial()
  • d5b80ab: 8299617: CurrencySymbols.properties is missing the copyright notice
  • 63cf4aa: 8299499: Usage of constructors of primitive wrapper classes should be avoided in java.net API docs
  • 5393dc9: Merge
  • 1f141bd: 8299705: JCov coverage runs depend on jdk_symbols
  • 5eee2a0: 8299740: CaptureCallState is missing @Preview annotation
  • 136f5db: 8299528: IR test: TestEor3AArch64.java fails on aarch64
  • 284c94e: 8298525: javadoc crashes with "UnsupportedOperationException: Not yet implemented" in SeeTaglet.inherit
  • 9c4ed16: 8299561: VaList.empty() doesn't return a list associated with the global scope
  • 7310131: 8299337: The java.awt.image.ColorModel#pData field is unused
  • ... and 20 more: https://git.openjdk.org/jdk/compare/a49ccb959b7e50ee67b1ab4feca47c34bdbc14fe...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

Going to push as commit 66db0bb.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 7068457: 8298472: AArch64: Detect Ampere-1 and Ampere-1A CPUs and set default options
  • 500c3c1: 8298730: Refactor subsystem_file_line_contents and add docs and tests
  • 4072412: 8298876: Swing applications do not get repainted coming out of sleep on Windows 10
  • a503ec2: 8299608: Add Register + imm32 orq to x86_64 assembler
  • d2827ec: 8299671: speed up compiler/intrinsics/string/TestStringLatin1IndexOfChar.java
  • 05a0a71: 8297933: [REDO] Compiler should only use verified interface types for optimization
  • 9b1ade8: 8295406: C1 crash with -XX:TypeProfileArgsLimit=0 -XX:TypeProfileLevel=222
  • 8d17d1e: 6914801: IPv6 unavailable if stdin is a socket
  • d03a5d9: 8299593: getprotobyname should not be used
  • c444922: 8218474: JComboBox display issue with GTKLookAndFeel
  • ... and 33 more: https://git.openjdk.org/jdk/compare/a49ccb959b7e50ee67b1ab4feca47c34bdbc14fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023
@openjdk openjdk bot closed this Jan 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@albertnetymk Pushed as commit 66db0bb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch January 9, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants