8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf

[calvinccheung]

Please review this simple fix for correcting the length passing tojio_snprintfin the get_dump_directory() function in jfrEmergencyDump.cpp.

Passed tiers 1 - 4 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11916/head:pull/11916
$ git checkout pull/11916

Update a local copy of the PR:
$ git checkout pull/11916
$ git pull https://git.openjdk.org/jdk pull/11916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11916

View PR using the GUI difftool:
$ git pr show -t 11916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11916.diff

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bf6383c7)

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297874: get_dump_directory() in jfrEmergencyDump.cpp should pass correct length to jio_snprintf

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 49 new commits pushed to the master branch:

• debe587: 8298381: Improve handling of session tickets for multiple SSLContexts
• eab1e62: 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack
• c8a8388: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
• 5f37cbe: 8297572: Remove unused PrecisionStyle::Precise
• f95346e: 8299261: Clean up AWT D3D exports
• 195f313: 8287925: AArch64: intrinsics for compareUnsigned method in Integer and Long
• 3a66737: 8299525: RISC-V: Add backend support for half float conversion intrinsics
• b7eb4e2: 8297306: Incorrect brackets in Javadoc for a constructor of IteratorSpliterator
• a638663: 8255119: Monitor::wait takes signed integer as timeout
• 4395578: Merge
• ... and 39 more: https://git.openjdk.org/jdk/compare/3dcf7001611aa66a7a1b4a01dfa6dfb296e70da1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mgronlun]

Thanks @calvinccheung, for fixing this. It is trivial, so go ahead and integrate.

[calvinccheung]

@mgronlun Thanks for the review.

/integrate

[openjdk]

Going to push as commit 5a51ef2.
Since your change was applied there have been 52 commits pushed to the master branch:

• a86b6f6: 8299183: Invokers.checkExactType passes parameters to create WMTE in opposite order
• 8b0133f: 8299259: C2: Div/Mod nodes without zero check could be split through iv phi of loop resulting in SIGFPE
• d68de02: 8299845: Remove obsolete comments in DirtyCardToOopClosure::get_actual_top
• debe587: 8298381: Improve handling of session tickets for multiple SSLContexts
• eab1e62: 8297487: G1 Remark: no need to keep alive oop constants of nmethods on stack
• c8a8388: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
• 5f37cbe: 8297572: Remove unused PrecisionStyle::Precise
• f95346e: 8299261: Clean up AWT D3D exports
• 195f313: 8287925: AArch64: intrinsics for compareUnsigned method in Integer and Long
• 3a66737: 8299525: RISC-V: Add backend support for half float conversion intrinsics
• ... and 42 more: https://git.openjdk.org/jdk/compare/3dcf7001611aa66a7a1b4a01dfa6dfb296e70da1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 5a51ef2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.