8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method

[plummercj]

VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) is not used. Furthermore it confuses the reader that runs across removeObjectMirror() calls, because what is actually being called is removeObjectMirror(SoftObjectReference ref).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11957/head:pull/11957
$ git checkout pull/11957

Update a local copy of the PR:
$ git checkout pull/11957
$ git pull https://git.openjdk.org/jdk pull/11957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11957

View PR using the GUI difftool:
$ git pr show -t 11957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11957.diff

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (dbd2f3d5)
• 00: Full (fa48e07c)

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method

Reviewed-by: alanb, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 283 new commits pushed to the master branch:

• 9887047: Merge
• 4b92fb0: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle
• 6a4a874: 8299034: Runtime::exec clarification of inherited environment
• 752a370: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
• 3918f9f: 8299090: Specify coordinate order for additional CaptureCallState parameters on class as well
• 33412c1: 8299677: Formatter.format might take a long time to format an integer or floating-point
• 7a85d95: 8298448: UndefinedBehaviorSanitizer
• 26890d1: 8296478: Rework 8282948 and 8282700 to use the new autoconf UTIL_ARG_WITH
• cf00d09: 8299330: Minor improvements in MSYS2 Workflow handling
• 48c8fb3: 8299978: Remove MethodHandleNatives.getMembers
• ... and 273 more: https://git.openjdk.org/jdk/compare/10737e168c967a08e257927251861bf2c14795ab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sspitsyn]

Looks good and simple. :)
Thanks,
Serguei

[plummercj]

/integrate

[openjdk]

Going to push as commit f4e119d.
Since your change was applied there have been 295 commits pushed to the master branch:

• 8cb25d3: 8298644: JNI call of getCurrentComponent on a wrong thread
• 500b45e: 8299865: Unnecessary NullPointerException catch in java.util.TimeZone#setDefaultZone
• 4ec3659: 8278349: JarSigner javadoc example uses SHA-1
• d117979: 8300054: Use static_assert in basic_types_init
• ce1193a: 8299976: Initialize static fields in Net eagerly
• 3ffc955: 8300099: Configuration fails to auto-detect build user through $USER in dockers
• e7fa150: 8299032: Interface IN_NATIVE oop stores for C2
• c250222: 8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt
• ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
• be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
• ... and 285 more: https://git.openjdk.org/jdk/compare/10737e168c967a08e257927251861bf2c14795ab...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit f4e119d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.