New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work #11959
Conversation
….lang.RuntimeException: Test failed, scroll on drag doesn't work
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
Webrevs
|
robot.mouseMove(scrollPane.getLocationOnScreen().x + 5, scrollPane.getLocationOnScreen().y + 5); | ||
robot.mousePress(InputEvent.BUTTON1_MASK); | ||
robot.delay(1000); | ||
robot.mouseMove(scrollPane.getLocationOnScreen().x + 5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The scrollPane should be accessed on EDT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix is fine and works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume it was tested in mach5
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 744 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@prsadhuk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
/integrate |
Going to push as commit 2c52cf0.
Your commit was automatically rebased without conflicts. |
Test probably was failing few years back due to samevm mode.
It's not failing now but made some robot safeguards.
Several iterations are passing in all CI platforms. Link in JBS.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11959/head:pull/11959
$ git checkout pull/11959
Update a local copy of the PR:
$ git checkout pull/11959
$ git pull https://git.openjdk.org/jdk pull/11959/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 11959
View PR using the GUI difftool:
$ git pr show -t 11959
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11959.diff