Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300140: ZipFile.isSignatureRelated returns true for files in META-INF subdirectories #11976

Closed
wants to merge 24 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
d219304
Files residing in subdirectories of META-INF/ should not be treated a…
eirbjo Jan 12, 2023
342b3c2
Merge branch 'master' into signature-related-subdirs
eirbjo Jan 12, 2023
95380a6
Use @modules tags instead of explicit --add-exports args
eirbjo Jan 14, 2023
b1b9d27
Simplify comment by removing a negative and changing "these paths" to…
eirbjo Jan 14, 2023
9813bbb
Merge branch 'master' into signature-related-subdirs
eirbjo Jan 14, 2023
828e083
Check that non-signature related .SF, .RSA files are treated as regul…
eirbjo Jan 14, 2023
209d12e
Check that JarSigner does not move unrelated [SF,RSA] files to the be…
eirbjo Jan 15, 2023
f264547
To ensure that the "unrelated signature files" code path of JarVerifi…
eirbjo Jan 15, 2023
6d0f690
Tag the test with the bug number
eirbjo Jan 15, 2023
808d1f4
Fix copyright year of newly added test
eirbjo Jan 16, 2023
d64d64b
Replacing File.createTempFile with Path.of lets jtreg handle retentio…
eirbjo Jan 18, 2023
beb7455
Style: Added whitespace separators between keyword and left parenthes…
eirbjo Jan 18, 2023
e9128f8
jarsigner -verify should also ignore unrelated signature files
eirbjo Jan 18, 2023
eadcc2c
Introduce SignatureFileVerifier.isInMetaInf as a common method to rep…
eirbjo Jan 18, 2023
0cd4cc4
Renaming the test to IgnoreUnrelatedSignatureFiles to make it clear t…
eirbjo Jan 18, 2023
e028356
Update copyright year of SignatureFileVerifier.java
eirbjo Jan 18, 2023
c3a1997
Update copyright year of s.s.t.jarsigner.Main.java
eirbjo Jan 18, 2023
65a0a6b
The update of SignatureFileVerifier.isSigningRelated to call isInMeta…
eirbjo Jan 18, 2023
3487362
The accidental regression where MANIFEST.MF was incorrecly not matche…
eirbjo Jan 18, 2023
b27d1a1
Add test coverage for matching of custom SIG-* files in SignatureFile…
eirbjo Jan 18, 2023
de3c678
Link to a more recent version of the JAR File Specification
eirbjo Jan 18, 2023
7aeef1c
Style: Add whitespace between if and left parenthesis
eirbjo Jan 18, 2023
cf93bfc
Improve test coverage of SignatureFileVerifier.isSigningRelated by ad…
eirbjo Jan 18, 2023
408d222
Add whitespace after keywords if and for
eirbjo Jan 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 1997, 2022, Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it