Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt #11987

Closed
wants to merge 1 commit into from

Conversation

stefank
Copy link
Member

@stefank stefank commented Jan 13, 2023

All known issues in JDK-8298058 have been fixed. Manual runs of ZGC + Fuzz don't reproduce any crashes. I'd like to unproblemlist so that we get more testing of ZGC and Loom.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11987/head:pull/11987
$ git checkout pull/11987

Update a local copy of the PR:
$ git checkout pull/11987
$ git pull https://git.openjdk.org/jdk pull/11987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11987

View PR using the GUI difftool:
$ git pr show -t 11987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11987.diff

@stefank
Copy link
Member Author

stefank commented Jan 13, 2023

/label add hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2023

👋 Welcome back stefank! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review hotspot-gc hotspot-gc-dev@openjdk.org labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@stefank
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 13, 2023

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@stefank This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300110: Unproblemlist Fuzz.java from ProblemList-zgc.txt

Reviewed-by: aboldtch, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
  • 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
  • 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
  • 9887047: Merge
  • 4b92fb0: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle
  • 6a4a874: 8299034: Runtime::exec clarification of inherited environment
  • 752a370: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • 3918f9f: 8299090: Specify coordinate order for additional CaptureCallState parameters on class as well
  • 33412c1: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • 7a85d95: 8298448: UndefinedBehaviorSanitizer
  • ... and 3 more: https://git.openjdk.org/jdk/compare/89d3f3d96b220c249e7b273a09cc3897428f8814...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 13, 2023
@stefank
Copy link
Member Author

stefank commented Jan 13, 2023

Thanks for the reviews!
/integrate

@openjdk
Copy link

openjdk bot commented Jan 13, 2023

Going to push as commit c250222.
Since your change was applied there have been 14 commits pushed to the master branch:

  • ac63f5f: 8297877: Risk for uninitialized memory in case of CHECK macro early return as part of field access
  • be8e6d0: 8299957: Enhance error logging in instrument coding with additional jplis_assert_msg
  • 640eff6: 8300040: TypeOopPtr::make_from_klass_common calls itself with args in wrong order
  • 19628e3: 8300068: UBSan CFLAGS/LDFLAGS not passed when building ADLC
  • 9887047: Merge
  • 4b92fb0: 8299918: Update Xcode11.3.1-MacOSX10.15 devkit at Oracle
  • 6a4a874: 8299034: Runtime::exec clarification of inherited environment
  • 752a370: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
  • 3918f9f: 8299090: Specify coordinate order for additional CaptureCallState parameters on class as well
  • 33412c1: 8299677: Formatter.format might take a long time to format an integer or floating-point
  • ... and 4 more: https://git.openjdk.org/jdk/compare/89d3f3d96b220c249e7b273a09cc3897428f8814...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 13, 2023
@openjdk openjdk bot closed this Jan 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2023
@openjdk
Copy link

openjdk bot commented Jan 13, 2023

@stefank Pushed as commit c250222.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stefank
Copy link
Member Author

stefank commented Jan 18, 2023

/backport jdk20

Edit: apparently this wasn't problem listed in jdk20. No need to backport anything.

@openjdk
Copy link

openjdk bot commented Jan 18, 2023

@stefank Could not automatically backport c2502228 to openjdk/jdk20 due to conflicts in the following files:

  • test/jdk/ProblemList-zgc.txt

Please fetch the appropriate branch/commit and manually resolve these conflicts by using the following commands in your personal fork of openjdk/jdk20. Note: these commands are just some suggestions and you can use other equivalent commands you know.

# Fetch the up-to-date version of the target branch
$ git fetch --no-tags https://git.openjdk.org/jdk20 master:master

# Check out the target branch and create your own branch to backport
$ git checkout master
$ git checkout -b stefank-backport-c2502228

# Fetch the commit you want to backport
$ git fetch --no-tags https://git.openjdk.org/jdk c250222880b815873f1b24119c58f9f9b50946a9

# Backport the commit
$ git cherry-pick --no-commit c250222880b815873f1b24119c58f9f9b50946a9
# Resolve conflicts now

# Commit the files you have modified
$ git add files/with/resolved/conflicts
$ git commit -m 'Backport c250222880b815873f1b24119c58f9f9b50946a9'

Once you have resolved the conflicts as explained above continue with creating a pull request towards the openjdk/jdk20 with the title Backport c250222880b815873f1b24119c58f9f9b50946a9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants