Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283203: Fix typo in SystemTray.getTrayIconSize javadoc #12020

Closed
wants to merge 2 commits into from

Conversation

SWinxy
Copy link
Contributor

@SWinxy SWinxy commented Jan 17, 2023

Please review this itty-bitty typo fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283203: Fix typo in SystemTray.getTrayIconSize javadoc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12020/head:pull/12020
$ git checkout pull/12020

Update a local copy of the PR:
$ git checkout pull/12020
$ git pull https://git.openjdk.org/jdk pull/12020/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12020

View PR using the GUI difftool:
$ git pr show -t 12020

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12020.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 17, 2023

👋 Welcome back SWinxy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@SWinxy The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 17, 2023

Webrevs

Copy link
Member

@aivanov-jdk aivanov-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this one. It looks good to me except for additional words in the description.

Could you also update the copyright year?

src/java.desktop/share/classes/java/awt/SystemTray.java Outdated Show resolved Hide resolved
@aivanov-jdk
Copy link
Member

I submitted JDK-8300280 regarding “…the size in pixels…”:

* Returns the size, in pixels, of the space that a tray icon will

@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@SWinxy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283203: Fix typo in SystemTray.getTrayIconSize javadoc

Reviewed-by: aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 75b122f: 8300120: Configure should support different defaults for CI/dev build environments
  • e139ec3: 8300069: Left shift of negative value in share/adlc/dict2.cpp
  • fb147aa: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path
  • 4cd166f: 8300125: Serial: Remove unused Generation::reset_saved_marks
  • 85d70ac: Merge
  • e15bdc5: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • b7fb8ef: 8299323: Allow extended registers for cmpw
  • 07d5753: 8300168: Typo in AccessibleJTableHeaderEntry javadoc
  • e82dc69: 8300205: Swing test bug8078268 make latch timeout configurable
  • 9a36f8a: 8299673: Simplify object pinning interactions with string deduplication
  • ... and 8 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aivanov-jdk) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2023
@SWinxy
Copy link
Contributor Author

SWinxy commented Jan 17, 2023

/integrate
:)

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@SWinxy
Your change (at version 5345e4b) is now ready to be sponsored by a Committer.

@SWinxy
Copy link
Contributor Author

SWinxy commented Jan 17, 2023

@TheShermanTanker if you're good to sponsor.

@aivanov-jdk
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 17, 2023

Going to push as commit 8c12ae8.
Since your change was applied there have been 20 commits pushed to the master branch:

  • e7e3712: 8300010: UnsatisfiedLinkError on calling System.console().readPassword() on Windows
  • 0b9ff06: 8300184: Optimize ResourceHashtableBase::iterate_all using _number_of_entries
  • 75b122f: 8300120: Configure should support different defaults for CI/dev build environments
  • e139ec3: 8300069: Left shift of negative value in share/adlc/dict2.cpp
  • fb147aa: 8300228: ModuleReader.find on exploded module throws if resource name maps to invalid file path
  • 4cd166f: 8300125: Serial: Remove unused Generation::reset_saved_marks
  • 85d70ac: Merge
  • e15bdc5: 8299789: Compilation of gtest causes build to fail if runtime libraries are in different dirs
  • b7fb8ef: 8299323: Allow extended registers for cmpw
  • 07d5753: 8300168: Typo in AccessibleJTableHeaderEntry javadoc
  • ... and 10 more: https://git.openjdk.org/jdk/compare/f52f6e65fba0360d3cf114e19fea402ab0d65eba...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 17, 2023
@openjdk openjdk bot closed this Jan 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 17, 2023
@openjdk
Copy link

openjdk bot commented Jan 17, 2023

@aivanov-jdk @SWinxy Pushed as commit 8c12ae8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@SWinxy SWinxy deleted the 8283203 branch January 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants