8300653: G1EvacInfo should use common naming scheme for collection set

[tschatzl]

Hi all,

please review this imo trivial renaming of some identifiers containing collectionset to collection_set.

Testing: local compilation

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300653: G1EvacInfo should use common naming scheme for collection set

Reviewers

• Albert Mingkun Yang (@albertnetymk - Reviewer)
• Ivan Walulya (@walulyai - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12096/head:pull/12096
$ git checkout pull/12096

Update a local copy of the PR:
$ git checkout pull/12096
$ git pull https://git.openjdk.org/jdk pull/12096/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12096

View PR using the GUI difftool:
$ git pr show -t 12096

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12096.diff

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e42c5459)

[albertnetymk]

I think cset is better (short and yet clear), but it's subjective.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300653: G1EvacInfo should use common naming scheme for collection set

Reviewed-by: ayang, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
• 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
• eca6479: 8300087: Replace NULL with nullptr in share/cds/
• 49d60fe: 8300172: java/net/httpclient/MappingResponseSubscriber.java failed with java.net.ConnectException
• e189397: 8296403: [TESTBUG] IR test runner methods in TestLongRangeChecks.java invoke wrong test methods
• 77f2d20: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions
• 93a933d: 8300400: Update --release 20 symbol information for JDK 20 build 32
• 9b97699: 8300586: Refactor code examples to use @snippet in java.text.Collator
• fbbb27e: 8300356: Refactor code examples to use @snippet in java.text.CollationElementIterator
• dfcd65c: Merge
• ... and 11 more: https://git.openjdk.org/jdk/compare/e326b86d37cec3b395b88598cf30ce4239732a15...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[walulyai]

I think cset is better (short and yet clear), but it's subjective.

I also prefer cset, but that might trigger further refactoring in other places where collection_set is already used.

[tschatzl]

We can always go back and rename as needed, but let's do that separately.

E.g. in class names like G1CSetSomething vs. G1CollectionSetSomething, the former with its four capitals one after another seems to be too cramped (particularly because after the following "et" there's another capital letter). However that may just my particular preference.
Spelling it out does not add another abbreviation (although this one is already present), making the code more approachable imo.

We have (had) various abbreviations for members (a few of them starting with "C") which also does not help too, so some additional fluff for better disambiguation seems good to me.

Anyway, enough of that rambling: Thanks for your reviews.

/integrate

[openjdk]

Going to push as commit 623ba5b.
Since your change was applied there have been 22 commits pushed to the master branch:

• 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
• 26410c1: 8281213: Unsafe uses of long and size_t in MemReporterBase::diff_in_current_scale
• eca6479: 8300087: Replace NULL with nullptr in share/cds/
• 49d60fe: 8300172: java/net/httpclient/MappingResponseSubscriber.java failed with java.net.ConnectException
• e189397: 8296403: [TESTBUG] IR test runner methods in TestLongRangeChecks.java invoke wrong test methods
• 77f2d20: 8287873: Add test for using -XX:+AutoCreateSharedArchive with different JDK versions
• 93a933d: 8300400: Update --release 20 symbol information for JDK 20 build 32
• 9b97699: 8300586: Refactor code examples to use @snippet in java.text.Collator
• fbbb27e: 8300356: Refactor code examples to use @snippet in java.text.CollationElementIterator
• ... and 12 more: https://git.openjdk.org/jdk/compare/e326b86d37cec3b395b88598cf30ce4239732a15...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit 623ba5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.