8300731: Avoid unnecessary array fill after creation in PaletteBuilder

[turbanoff]

No need to fill elements of array with null: it was just created. Java guarantees that all elements of array are nulls anyway.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8300731: Avoid unnecessary array fill after creation in PaletteBuilder

Reviewers

• @SWinxy (no known github.com user name / role)
• Phil Race (@prrace - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12101/head:pull/12101
$ git checkout pull/12101

Update a local copy of the PR:
$ git checkout pull/12101
$ git pull https://git.openjdk.org/jdk pull/12101/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12101

View PR using the GUI difftool:
$ git pr show -t 12101

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12101.diff

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mrserb]

looks fine

[mlbridge]

Webrevs

• 00: Full (08c21f30)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300731: Avoid unnecessary array fill after creation in PaletteBuilder

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
• 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced
• facd415: 8297757: VarHandles.getStaticFieldFromBaseAndOffset should get the receiver type from VarHandle
• e803855: 8299863: URLFromURITest.java should import org.junit.jupiter.api.Test
• 92d8326: 8299827: Add resolved IP address in connection exception for sockets
• c6d5600: 8038146: Clarify Map.Entry's connection to the underlying map
• b2d3622: 8299896: Reduce enum values of HtmlLinkInfo.Kind
• 623ba5b: 8300653: G1EvacInfo should use common naming scheme for collection set
• 97c611d: 8289748: C2 compiled code crashes with SIGFPE with -XX:+StressLCM and -XX:+StressGCM
• 4562b40: 8300682: InstanceKlassMiscStatus is a bad name
• ... and 13 more: https://git.openjdk.org/jdk/compare/80ab50b3389cbdae6bced7cea3f3a84b94c5bb82...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[turbanoff]

/integrate

[openjdk]

Going to push as commit cbfc069.
Since your change was applied there have been 31 commits pushed to the master branch:

• 67b1c89: 8294693: Add Collections.shuffle overload that accepts RandomGenerator interface
• c8dd758: 8300260: Remove metaprogramming/isSame.hpp
• a6c2a2a: 8300692: GCC 12 reports some compiler warnings in bundled freetype
• bb42e61: 8300493: Use ArraysSupport.vectorizedHashCode in j.u.zip.ZipCoder
• 06394ee: 8300590: [JVMCI] BytecodeFrame.equals is broken
• 5331a3e: 8298908: Instrument Metaspace for ASan
• e1ee672: 8300725: Improve performance of ColorConvertOp for default destinations with alpha
• 7c2f77a: 8300584: Accelerate AVX-512 CRC32C for small buffers
• 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
• 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced
• ... and 21 more: https://git.openjdk.org/jdk/compare/80ab50b3389cbdae6bced7cea3f3a84b94c5bb82...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit cbfc069.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.