Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk20 #12103

Closed
wants to merge 3 commits into from
Closed

Merge jdk20 #12103

wants to merge 3 commits into from

Conversation

JesperIRL
Copy link
Member

@JesperIRL JesperIRL commented Jan 19, 2023

Forwardport JDK 20 -> JDK 21


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12103/head:pull/12103
$ git checkout pull/12103

Update a local copy of the PR:
$ git checkout pull/12103
$ git pull https://git.openjdk.org/jdk pull/12103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12103

View PR using the GUI difftool:
$ git pr show -t 12103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12103.diff

RealCLanger and others added 3 commits January 19, 2023 06:43
…tly handled after JDK-8293550

Reviewed-by: erikj
Co-authored-by: Fei Yang <fyang@openjdk.org>
Co-authored-by: Richard Reingruber <rrich@openjdk.org>
Reviewed-by: dlong, pchilanomate
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2023

👋 Welcome back jwilhelm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@JesperIRL This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@JesperIRL The following labels will be automatically applied to this pull request:

  • build
  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jan 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2023

Webrevs

@JesperIRL
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 19, 2023

Going to push as commit dfcd65c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f2a1eb9: 8300698: Missing @SInCE tag for ClassFileFormatVersion.RELEASE_21

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 19, 2023
@openjdk openjdk bot closed this Jan 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2023
@openjdk
Copy link

openjdk bot commented Jan 19, 2023

@JesperIRL Pushed as commit dfcd65c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JesperIRL JesperIRL deleted the Merge_jdk20 branch January 20, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants