New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300693: Lower the compile threshold and reduce the iterations of warmup loop in VarHandles tests #12104
Conversation
…mup loop in VarHandles tests
👋 Welcome back mchung! A progress list of the required criteria for merging this PR into |
Webrevs
|
test/jdk/java/lang/invoke/VarHandles/VarHandleTestAccessBoolean.java
Outdated
Show resolved
Hide resolved
@mlchung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 43 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks god. Thanks.
/integrate |
Going to push as commit 86fed79.
Your commit was automatically rebased without conflicts. |
java/lang/invoke/VarHandles
tests run with C1, C2 and tiered compilations and the test cases are executed in the warm up loop with 20000 iterations to verify C1, C2 intrinsics. Default Tier4CompileThreshold is 15000.This PR proposes to scale the compile threshold to 0.1 such that the warm up loop can be reduced to 2000 iterations. This will speed up the test execution time.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12104/head:pull/12104
$ git checkout pull/12104
Update a local copy of the PR:
$ git checkout pull/12104
$ git pull https://git.openjdk.org/jdk pull/12104/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 12104
View PR using the GUI difftool:
$ git pr show -t 12104
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12104.diff