Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300587: (bf) Some covariant overrides are missing @since tags #12123

Closed
wants to merge 1 commit into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Jan 20, 2023

Reinstate @since 9 tags for MappedByteBuffer and $TypeBuffer covariant overrides.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12123/head:pull/12123
$ git checkout pull/12123

Update a local copy of the PR:
$ git checkout pull/12123
$ git pull https://git.openjdk.org/jdk pull/12123/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12123

View PR using the GUI difftool:
$ git pr show -t 12123

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12123.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 20, 2023

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 20, 2023
@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jan 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 20, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 20, 2023

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300587: (bf) Some covariant overrides are missing @since tags

Reviewed-by: lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5784eb7: 8300721: Cleanup ProblemList-svc-vthread.txt
  • 9d44dd0: 8297972: Poly1305 Endianness on ByteBuffer not enforced

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 20, 2023
@bplb
Copy link
Member Author

bplb commented Jan 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2023

Going to push as commit 542bfe6.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 03a9a88: 8300265: Remove metaprogramming/isSigned.hpp
  • 5a4945c: 8299975: Limit underflow protection CMoveINode in PhaseIdealLoop::do_unroll must also protect type from underflow
  • f307e8c: 8299795: Relativize locals in interpreter frames
  • 11aadc9: 8244400: MenuItem may cache the size and did not update it when the screen DPI is changed
  • 836198a: 8300591: @SuppressWarnings option "lossy-conversions" missing from jdk.compiler module javadoc
  • 45e4e00: 8300079: SIGSEGV in LibraryCallKit::inline_string_copy due to constant NULL src argument
  • 030b071: 8300207: Add a pre-check for the number of canonical equivalent permutations in j.u.r.Pattern
  • 7ced08d: 8300638: Tier1 IR Test failure after JDK-8298632 on macosx-x64-debug
  • 3ea4eac: 8300817: The build is broken after JDK-8294693
  • cbfc069: 8300731: Avoid unnecessary array fill after creation in PaletteBuilder
  • ... and 10 more: https://git.openjdk.org/jdk/compare/facd41511b972e940ecab3bc57f5f23efca43343...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2023
@openjdk openjdk bot closed this Jan 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2023
@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@bplb Pushed as commit 542bfe6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the covariant-since-8300587 branch January 23, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
3 participants