Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300817: The build is broken after JDK-8294693 #12129

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Jan 21, 2023

The next warning is fixed:

 === Output from failing command(s) repeated here ===
* For target jdk_modules_java.base__the.java.base_batch:
/home/runner/work/jdk/jdk/src/java.base/share/classes/java/util/Collections.java:462: warning: empty <p> tag
     * position, inclusive.<p>
                           ^
error: warnings found and -Werror specified 

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12129/head:pull/12129
$ git checkout pull/12129

Update a local copy of the PR:
$ git checkout pull/12129
$ git pull https://git.openjdk.org/jdk pull/12129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12129

View PR using the GUI difftool:
$ git pr show -t 12129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12129.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2023

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review January 21, 2023 19:50
@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@mrserb The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Jan 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 21, 2023

Webrevs

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300817: The build is broken after JDK-8294693

Reviewed-by: tvaleev, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • cbfc069: 8300731: Avoid unnecessary array fill after creation in PaletteBuilder

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 21, 2023
@mrserb
Copy link
Member Author

mrserb commented Jan 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2023

Going to push as commit 3ea4eac.
Since your change was applied there has been 1 commit pushed to the master branch:

  • cbfc069: 8300731: Avoid unnecessary array fill after creation in PaletteBuilder

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2023
@openjdk openjdk bot closed this Jan 21, 2023
@mrserb mrserb deleted the JDK-8300817 branch January 21, 2023 21:55
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2023
@openjdk
Copy link

openjdk bot commented Jan 21, 2023

@mrserb Pushed as commit 3ea4eac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants