8285850 : [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

[deepa181]

basic_tools.m4 contains the line 'elif test "x$TAR_TYPE" = "aix";...' The comparison "x$TAR_TYPE" = "aix" can never be true. Adding an 'x' to both sides of the comparison prevents an erroneous match when the variable is the empty string.

Verified the test after successful build and reflecting changes 'elif test "x$TAR_TYPE" = "xaix";...' on generated-configure.sh file.

Reported Issue : JDK-8285850

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8285850: [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)
• Tyler Steele (@backwaterred - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12146/head:pull/12146
$ git checkout pull/12146

Update a local copy of the PR:
$ git checkout pull/12146
$ git pull https://git.openjdk.org/jdk pull/12146/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12146

View PR using the GUI difftool:
$ git pr show -t 12146

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12146.diff

[bridgekeeper]

Hi @deepa181, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user deepa181" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@deepa181 The following labels will be automatically applied to this pull request:

• build
• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[openjdk]

@deepa181 Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[deepa181]

/covered

[deepa181]

Hi @deepa181, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user deepa181" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[mlbridge]

Webrevs

• 00: Full (c49bef03)

[erikj79]

That is indeed a mistake, thanks for spotting it. Makes me wonder if the build worked on AIX.

[openjdk]

@deepa181 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285850: [AIX] unreachable code in basic_tools.m4 -> BASIC_CHECK_TAR

Reviewed-by: erikj, tsteele

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 394 new commits pushed to the master branch:

• f7da09c: 8301164: Remove unused ResourceStack class
• 6e4710b: 8300253: Introduce AArch64 nzcv accessors
• c6b3f2d: 8301129: Link to debuginfo files should only be made after stripping
• 938b409: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
• 0eb1f66: 8298038: [s390] Configure script detects num_cores +1
• c3ff151: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
• 7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider
• d6007a3: 8298869: Update ConnectionTest.java for changes to TLS implementation
• c427814: 8299982: (bf) Buffer.checkIndex(int, int) should use Preconditions.checkIndex(int, int, BiFunction)
• 7ddafd7: 8301189: validate-source fails after JDK-8298873
• ... and 384 more: https://git.openjdk.org/jdk/compare/82deb5ca615f70634f8cd84836265d01edd1c5a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@erikj79, @backwaterred) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[deepa181]

/integrate

[openjdk]

@deepa181
Your change (at version c49bef0) is now ready to be sponsored by a Committer.

[backwaterred]

/sponsor

[openjdk]

Going to push as commit dff4131.
Since your change was applied there have been 402 commits pushed to the master branch:

• e2a3b20: 8301187: Memory leaks in OopMapCache
• fccf818: 8301123: Enable Symbol refcounting underflow checks in PRODUCT
• e4252bb: 8300823: UB: Compile::_phase_optimize_finished is initialized too late
• db8fa1b: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
• 3758487: 8301180: Replace NULL with nullptr in share/gc/parallel/
• d7aa87f: 8300176: URLEncoder/URLDecoder static fields should be private static final
• 107e184: 8301179: Replace NULL with nullptr in share/gc/serial/
• b77abc6: 8301178: Replace NULL with nullptr in share/gc/epsilon/
• f7da09c: 8301164: Remove unused ResourceStack class
• 6e4710b: 8300253: Introduce AArch64 nzcv accessors
• ... and 392 more: https://git.openjdk.org/jdk/compare/82deb5ca615f70634f8cd84836265d01edd1c5a5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@backwaterred @deepa181 Pushed as commit dff4131.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.