Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8290918: Initial nroff manpage generation for JDK 21 #12154

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 23, 2023

Please review this simple update to the manpage to set the version to 21-ea.

This change also corrects a typo in javac.1 that was manually introduced by JDK-8300591

Thanks.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8290918: Initial nroff manpage generation for JDK 21

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12154/head:pull/12154
$ git checkout pull/12154

Update a local copy of the PR:
$ git checkout pull/12154
$ git pull https://git.openjdk.org/jdk pull/12154/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12154

View PR using the GUI difftool:
$ git pr show -t 12154

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12154.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2023

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2023
@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@dholmes-ora The following labels will be automatically applied to this pull request:

  • compiler
  • core-libs
  • hotspot-jfr
  • javadoc
  • kulla
  • net
  • security
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added javadoc javadoc-dev@openjdk.org serviceability serviceability-dev@openjdk.org security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org net net-dev@openjdk.org compiler compiler-dev@openjdk.org kulla kulla-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org labels Jan 23, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 23, 2023

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8290918: Initial nroff manpage generation for JDK 21

Reviewed-by: lancea, iris, darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • b3822f5: 8300589: Use @snippet and @linkplain in java.text.CollationKey and java.text.CompactNumberFormat
  • afd5921: 8298610: Refactor archiving of ConstantPool::resolved_references()
  • 937ba1c: 8300111: Add rpath for common lib locations for jpackageapplauncher
  • 2da2e5a: 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
  • 0323609: 8300706: Use @snippet in java.text
  • b5ee3d1: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • 77a5010: 8286775: Remove identical per-compiler definitions of unsigned integral jtypes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2023
@dholmes-ora
Copy link
Member Author

Thanks for the review @LanceAndersen

@dholmes-ora
Copy link
Member Author

Thanks for the review @irisclark !

@dholmes-ora
Copy link
Member Author

Thanks for the review @jddarcy !

I think that suffices for this trivial change.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 24, 2023

Going to push as commit 6dd8723.
Since your change was applied there have been 7 commits pushed to the master branch:

  • b3822f5: 8300589: Use @snippet and @linkplain in java.text.CollationKey and java.text.CompactNumberFormat
  • afd5921: 8298610: Refactor archiving of ConstantPool::resolved_references()
  • 937ba1c: 8300111: Add rpath for common lib locations for jpackageapplauncher
  • 2da2e5a: 8300946: Add sun/security/provider/certpath/OCSP/OCSPNoContentLength to ProblemList
  • 0323609: 8300706: Use @snippet in java.text
  • b5ee3d1: 8299497: Usage of constructors of primitive wrapper classes should be avoided in java.desktop API docs
  • 77a5010: 8286775: Remove identical per-compiler definitions of unsigned integral jtypes

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 24, 2023
@openjdk openjdk bot closed this Jan 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 24, 2023
@openjdk
Copy link

openjdk bot commented Jan 24, 2023

@dholmes-ora Pushed as commit 6dd8723.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8290918-manpage branch June 27, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org core-libs core-libs-dev@openjdk.org hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated javadoc javadoc-dev@openjdk.org kulla kulla-dev@openjdk.org net net-dev@openjdk.org security security-dev@openjdk.org serviceability serviceability-dev@openjdk.org
4 participants