Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301148: Serial: Remove ContiguousSpace::reset_saved_mark #12215

Closed

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jan 26, 2023

Simple change of removing redundant code.

Test: hotspot_gc


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8301148: Serial: Remove ContiguousSpace::reset_saved_mark

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12215/head:pull/12215
$ git checkout pull/12215

Update a local copy of the PR:
$ git checkout pull/12215
$ git pull https://git.openjdk.org/jdk pull/12215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12215

View PR using the GUI difftool:
$ git pr show -t 12215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2023

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8301148 8301148: Serial: Remove ContiguousSpace::reset_saved_mark Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@albertnetymk Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2023
@openjdk
Copy link

openjdk bot commented Jan 26, 2023

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2023

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Jan 27, 2023

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301148: Serial: Remove ContiguousSpace::reset_saved_mark

Reviewed-by: kbarrett, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

  • 08b24ac: 8294066: IGV: Graph changes when deleting a graph in the same group with smaller index
  • 3db558b: 8300915: G1: incomplete SATB because nmethod entry barriers don't get armed
  • cbefe1f: 8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le
  • c2ebd17: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails
  • 4bd3f0a: 8301088: oopDesc::print_on should consistently use a trailing newline
  • 64b25ea: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ
  • 1ff4646: 8298612: Refactor archiving of java String objects
  • d4e9f5e: 8238170: BeanContextSupport remove and propertyChange can deadlock
  • 6475501: 8300208: Optimize Adler32 stub for AVX-512 targets.
  • af564e4: 8299844: RISC-V: Implement _onSpinWait intrinsic
  • ... and 42 more: https://git.openjdk.org/jdk/compare/da80e7a489684cdc5d52ac07868961f889f2dc34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2023
@albertnetymk
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2023

Going to push as commit 82df4a2.
Since your change was applied there have been 56 commits pushed to the master branch:

  • c672ed1: 8301248: Less side effects in InstanceRefKlass::trace_reference_gc
  • cee4bd3: 8301047: Clean up type unsafe uses of oop from compiler code
  • 7fae3a1: 8301229: Clean up SuspendibleThreadSet::_suspend_all
  • f50cda7: 8301217: Remove FilteringClosure
  • 08b24ac: 8294066: IGV: Graph changes when deleting a graph in the same group with smaller index
  • 3db558b: 8300915: G1: incomplete SATB because nmethod entry barriers don't get armed
  • cbefe1f: 8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le
  • c2ebd17: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails
  • 4bd3f0a: 8301088: oopDesc::print_on should consistently use a trailing newline
  • 64b25ea: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ
  • ... and 46 more: https://git.openjdk.org/jdk/compare/da80e7a489684cdc5d52ac07868961f889f2dc34...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2023
@openjdk openjdk bot closed this Jan 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2023
@openjdk
Copy link

openjdk bot commented Jan 30, 2023

@albertnetymk Pushed as commit 82df4a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-remove-reset_saved_mark branch January 30, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants