8301047: Clean up type unsafe uses of oop from compiler code

[fisk]

In an ideal world, when you have an oop, its contents should also be an oop. It happens, however, that we have other forms of pointers sometimes, used with the oop type, in some compiler code. We should clean that up.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8301047: Clean up type unsafe uses of oop from compiler code

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Stefan Karlsson (@stefank - Reviewer)

Contributors

• Axel Boldt-Christmas <aboldtch@openjdk.org>
• Stefan Karlsson <stefank@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/12223/head:pull/12223
$ git checkout pull/12223

Update a local copy of the PR:
$ git checkout pull/12223
$ git pull https://git.openjdk.org/jdk pull/12223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12223

View PR using the GUI difftool:
$ git pr show -t 12223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/12223.diff

[bridgekeeper]

👋 Welcome back eosterlund! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fisk The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[fisk]

/contributor add @xmas92

[fisk]

/contributor add @stefank

[openjdk]

@fisk
Contributor Axel Boldt-Christmas <aboldtch@openjdk.org> successfully added.

[openjdk]

@fisk
Contributor Stefan Karlsson <stefank@openjdk.org> successfully added.

[mlbridge]

Webrevs

• 00: Full (d5ee3402)

[vnkozlov]

Looks reasonable.

[openjdk]

@fisk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301047: Clean up type unsafe uses of oop from compiler code

Co-authored-by: Axel Boldt-Christmas <aboldtch@openjdk.org>
Co-authored-by: Stefan Karlsson <stefank@openjdk.org>
Reviewed-by: kvn, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 88 new commits pushed to the master branch:

• d7aa87f: 8300176: URLEncoder/URLDecoder static fields should be private static final
• 107e184: 8301179: Replace NULL with nullptr in share/gc/serial/
• b77abc6: 8301178: Replace NULL with nullptr in share/gc/epsilon/
• f7da09c: 8301164: Remove unused ResourceStack class
• 6e4710b: 8300253: Introduce AArch64 nzcv accessors
• c6b3f2d: 8301129: Link to debuginfo files should only be made after stripping
• 938b409: 8301133: IGV: NPE occurs when creating a diff graph with a graph in a different folder
• 0eb1f66: 8298038: [s390] Configure script detects num_cores +1
• c3ff151: 8301190: [vectorapi] The typeChar of LaneType is incorrect when default locale is tr
• 7eff578: 8288050: Add support of SHA-512/224 and SHA-512/256 to the PBKDF2 and PBES2 impls in SunJCE provider
• ... and 78 more: https://git.openjdk.org/jdk/compare/5a4945c0d95423d0ab07762c915e9cb4d3c66abb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[fisk]

Thanks for the review @vnkozlov!

[fisk]

Thanks for the review, @stefank!

[fisk]

/integrate

[openjdk]

Going to push as commit cee4bd3.
Since your change was applied there have been 120 commits pushed to the master branch:

• 7fae3a1: 8301229: Clean up SuspendibleThreadSet::_suspend_all
• f50cda7: 8301217: Remove FilteringClosure
• 08b24ac: 8294066: IGV: Graph changes when deleting a graph in the same group with smaller index
• 3db558b: 8300915: G1: incomplete SATB because nmethod entry barriers don't get armed
• cbefe1f: 8301163: jdk/internal/vm/Continuation/Fuzz.java increase COMPILATION_TIMEOUT for Linux ppc64le
• c2ebd17: 6187113: DefaultListSelectionModel.removeIndexInterval(0, Integer.MAX_VALUE) fails
• 4bd3f0a: 8301088: oopDesc::print_on should consistently use a trailing newline
• 64b25ea: 8291569: Consider removing JNI checks for signals SIGPIPE and SIGXFSZ
• 1ff4646: 8298612: Refactor archiving of java String objects
• d4e9f5e: 8238170: BeanContextSupport remove and propertyChange can deadlock
• ... and 110 more: https://git.openjdk.org/jdk/compare/5a4945c0d95423d0ab07762c915e9cb4d3c66abb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@fisk Pushed as commit cee4bd3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.